-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live tests: update README #37512
Live tests: update README #37512
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@@ -119,7 +119,8 @@ You can run the existing test suites with the following command: | |||
#### With local connection objects (`config.json`, `catalog.json`, `state.json`) | |||
```bash | |||
poetry run pytest src/live_tests/regression_tests \ | |||
--connector-image=airbyte/source-faker \ | |||
--connector-image=airbyte/source-faker \ | |||
--connection-id=<CONNECTION-ID> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide a way to easily get a working connection-id for this command? I think this would be great because the users going through the readme.md will probably be complete beginners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have some tooling for automatically picking a connection ID merged soon. But I think that people should really still be using the onboarding doc. Explanation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer completely removing pipx
from the install instructions as it's confusing and less reliable than poetry
(which we must use to run the pytest suite)
IMO install should just be:
poetry install
To run debug
you'd then run:
poetry run live-tests debug
To run the regression test suite:
poetry run pytest src/live_tests/regression_tests ...
c670d9e
to
f999c5a
Compare
Thanks @alafanechere I made these updates. |
Updates the live-tests README to indicate that
poetry
should be used to install the virtual environment, and that a connection ID is required for regression tests.