🐛 Source Salesforce: Break Python application with status 1 on exception #37419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
brianjlai
approved these changes
Apr 18, 2024
maxi297
deleted the
maxi297/salesforce-breaking-with-status-code-not-equal-to-1
branch
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To fail an attempt, the return code from the source should be != 0. Since the change to support partitioned state, this is not the case for Concurrent CDK. This change ensure that if there was an exception, we return status code 1.
How
Update CDK version following #37390
The rest is updating the tests based on this new exception that is thrown
User Impact
Error will be reported properly as it needs error code != 0 to be reported
Can this PR be safely reverted and rolled back?