Break Python application with status 1 on exception #37390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
maxi297/fix_partitioned_state_saving_issue
to
master
April 18, 2024 02:57
maxi297
commented
Apr 18, 2024
| # We still raise at least one exception when a stream raises an exception because the platform currently relies | ||
| # on a non-zero exit code to determine if a sync attempt has failed. We also raise the exception as a config_error | ||
| # type because this combined error isn't actionable, but rather the previously emitted individual errors. | ||
| raise AirbyteTracedException(message=error_message, internal_message="Concurrent read failure", failure_type=FailureType.config_error) |
There was a problem hiding this comment.
Having a internal_message is different than abstract_source. I had to add an internal message as the scenario framework will assert on the internal_message. Leaving this empty would generate 'NoneType' object is not subscriptable
…s-code-not-equal-to-1
|
Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at [email protected] |
maxi297
commented
Apr 18, 2024
airbyte-cdk/python/unit_tests/sources/streams/concurrent/test_concurrent_read_processor.py
Show resolved
Hide resolved
brianjlai
approved these changes
Apr 18, 2024
airbyte-cdk/python/airbyte_cdk/sources/concurrent_source/concurrent_read_processor.py
Outdated
Show resolved
Hide resolved
brianjlai
approved these changes
Apr 18, 2024
maxi297
deleted the
maxi297/concurrent-cdk-breaking-with-status-code-not-equal-to-1
branch
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To fail an attempt, the return code from the source should be != 0. Since the change to support partitioned state, this is not the case for Concurrent CDK. This change ensure that if there was an exception, we return status code 1.
How
If
ConcurrentReadProcessoris done and there were exceptions, instead of returning "true", we raise an config_error like the abstract source does. The error needs to be a config_error to avoid paged alert.Review guide
airbyte-cdk/python/airbyte_cdk/sources/concurrent_source/concurrent_read_processor.pyairbyte-cdk/python/unit_tests/sources/streams/concurrent/test_concurrent_read_processor.pyThe rest is updating the tests based on this new exception that is thrown
User Impact
This is unclear to me but my understanding based on discussion with @brianjlai is that we can have sync attempts that are classified as successful even though there were AirbyteTraceMessage of type system_error
Can this PR be safely reverted and rolled back?