Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update telemetry attributes to match other data #37008

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Apr 11, 2024

  • update attributes to match other scripts

Ellipsis 🚀 This PR description was created by Ellipsis for commit 0ba5b95.

Summary:

This PR refactors the run-ab-platform.sh script to use readonly variables for telemetry event states and types, and updates the deployment_mode attribute to deployment_method in the TelemetrySend function.

Key points:

  • Updated telemetry attributes in run-ab-platform.sh.
  • Replaced hardcoded strings with readonly variables for event states and types.
  • Updated deployment_mode attribute to deployment_method in TelemetrySend function.

Generated with ❤️ by ellipsis.dev

@colesnodgrass colesnodgrass requested a review from bgroff April 11, 2024 21:39
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Apr 11, 2024 9:39pm

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 0ba5b95
  • Looked at 103 lines of code in 1 files
  • Took 39 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. run-ab-platform.sh:51:
  • Assessed confidence : 0%
  • Comment:
    Good use of readonly variables for event states and types. This makes the code more maintainable and less prone to errors.
  • Reasoning:
    The PR author has replaced hardcoded strings with readonly variables for event states and types. This is a good practice as it reduces the chance of typos and makes it easier to manage these values. The changes are consistent and correctly implemented throughout the script.

Workflow ID: wflow_L6fQGVizUeAnQIdy


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@colesnodgrass colesnodgrass merged commit 4a4a9c2 into master Apr 11, 2024
28 checks passed
@colesnodgrass colesnodgrass deleted the cole/update-telemetry-attrs branch April 11, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants