Skip to content

Commit 4a4a9c2

Browse files
update telemetry attributes to match other data (#37008)
1 parent f30f678 commit 4a4a9c2

File tree

1 file changed

+26
-16
lines changed

1 file changed

+26
-16
lines changed

run-ab-platform.sh

+26-16
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,16 @@ all_files="$docker_compose_yaml $docker_compose_debug_yaml $dot_env $dot_env_dev
4747

4848
base_github_url="https://raw.githubusercontent.com/airbytehq/airbyte-platform/v$VERSION/"
4949

50+
# event states are used for telemetry data
51+
readonly eventStateStarted="started"
52+
readonly eventStateFailed="failed"
53+
readonly eventStateSuccess="succeeded"
54+
55+
# event types are used for telemetry data
56+
readonly eventTypeDownload="download"
57+
readonly eventTypeInstall="install"
58+
readonly eventTypeRefresh="refresh"
59+
5060
telemetrySuccess=false
5161
telemetrySessionULID=""
5262
telemetryUserULID=""
@@ -112,7 +122,7 @@ TelemetryDockerUp()
112122
while [ $SECONDS -lt $end ]; do
113123
webappState=$(docker compose ps --all --format "{{.Service}}:{{.State}}" 2>/dev/null | grep server | cut -d ":" -f2 | xargs)
114124
if [ "$webappState" = "running" ]; then
115-
TelemetrySend "success" "install"
125+
TelemetrySend $eventStateSuccess $eventTypeInstall
116126
break
117127
fi
118128
sleep 1
@@ -144,7 +154,7 @@ TelemetrySend()
144154
"anonymousId":"$telemetryUserULID",
145155
"event":"$event",
146156
"properties": {
147-
"deployment_mode":"run_ab",
157+
"deployment_method":"run_ab",
148158
"session_id":"$telemetrySessionULID",
149159
"state":"$state",
150160
"os":"$OSTYPE",
@@ -235,20 +245,20 @@ done
235245
for argument in $args; do
236246
case $argument in
237247
-d | --download)
238-
TelemetrySend "start" "download"
239-
trap 'TelemetrySend "failed" "download" "sigint"' SIGINT
240-
trap 'TelemetrySend "failed" "download" "sigterm"' SIGTERM
248+
TelemetrySend $eventStateStarted $eventTypeDownload
249+
trap 'TelemetrySend $eventStateFailed $eventTypeDownload "sigint"' SIGINT
250+
trap 'TelemetrySend $eventStateFailed $eventTypeDownload "sigterm"' SIGTERM
241251
Download
242-
TelemetrySend "success" "download"
252+
TelemetrySend $eventStateSuccess $eventTypeDownload
243253
exit
244254
;;
245255
-r | --refresh)
246-
TelemetrySend "start" "refresh"
247-
trap 'TelemetrySend "failed" "refresh" "sigint"' SIGINT
248-
trap 'TelemetrySend "failed" "refresh" "sigterm"' SIGTERM
256+
TelemetrySend $eventStateStarted $eventTypeRefresh
257+
trap 'TelemetrySend $eventStateFailed $eventTypeRefresh "sigint"' SIGINT
258+
trap 'TelemetrySend $eventStateFailed $eventTypeRefresh "sigterm"' SIGTERM
249259
DeleteLocalAssets
250260
Download
251-
TelemetrySend "success" "refresh"
261+
TelemetrySend $eventStateSuccess $eventTypeRefresh
252262
exit
253263
;;
254264
-x | --debug)
@@ -272,9 +282,9 @@ for argument in $args; do
272282
esac
273283
done
274284

275-
TelemetrySend "start" "install"
276-
trap 'TelemetrySend "failed" "install" "sigint"' SIGINT
277-
trap 'TelemetrySend "failed" "install" "sigterm"' SIGTERM
285+
TelemetrySend $eventStateStarted $eventTypeInstall
286+
trap 'TelemetrySend $eventStateFailed $eventTypeInstall "sigint"' SIGINT
287+
trap 'TelemetrySend $eventStateFailed $eventTypeInstall "sigterm"' SIGTERM
278288

279289
########## Pointless Banner for street cred ##########
280290
# Make sure the console is huuuge
@@ -296,7 +306,7 @@ fi
296306
########## Dependency Check ##########
297307
if ! docker compose version >/dev/null 2>/dev/null; then
298308
echo -e "$red_text""docker compose v2 not found! please install docker compose!""$default_text"
299-
TelemetrySend "failed" "install" "docker compose not installed"
309+
TelemetrySend $eventStateFailed $eventTypeInstall "docker compose not installed"
300310
exit 1
301311
fi
302312

@@ -325,9 +335,9 @@ docker compose up $dockerDetachedMode
325335
if test $? -ne 0; then
326336
echo -e "$red_text""Docker compose failed. If you are seeing container conflicts""$default_text"
327337
echo -e "$red_text""please consider removing old containers""$default_text"
328-
TelemetrySend "failed" "install" "docker compose failed"
338+
TelemetrySend $eventStateFailed $eventTypeInstall "docker compose failed"
329339
else
330-
TelemetrySend "success" "install"
340+
TelemetrySend $eventStateSuccess $eventTypeInstall
331341
fi
332342

333343
########## Ending Docker ##########

0 commit comments

Comments
 (0)