-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling spotbugs for datastore-postgres submodule #36704
Merged
stephane-airbyte
merged 1 commit into
master
from
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
Apr 3, 2024
Merged
enabling spotbugs for datastore-postgres submodule #36704
stephane-airbyte
merged 1 commit into
master
from
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 29, 2024
5ea1369
to
5bd0fe9
Compare
1c4ccac
to
8c92b70
Compare
5bd0fe9
to
6dea953
Compare
8c92b70
to
8315c7e
Compare
postamar
approved these changes
Apr 2, 2024
@@ -108,12 +108,11 @@ internal class PostgresUtilsTest { | |||
} | |||
|
|||
companion object { | |||
lateinit var PSQL_DB: PostgreSQLContainer<Nothing> | |||
var PSQL_DB: PostgreSQLContainer<Nothing> = PostgreSQLContainer<Nothing>("postgres:13-alpine") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you could even call the start()
method using run
or apply
or whichever scoped method is best and get rid of init()
entirely.
6dea953
to
9236984
Compare
8315c7e
to
34b730f
Compare
9236984
to
18c552f
Compare
34b730f
to
8d4840e
Compare
18c552f
to
6105dec
Compare
8d4840e
to
8b6a839
Compare
6105dec
to
af9fd95
Compare
8b6a839
to
796089c
Compare
Merge activity
|
af9fd95
to
47c584c
Compare
796089c
to
910e05c
Compare
47c584c
to
72f4502
Compare
Base automatically changed from
stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule
to
master
April 3, 2024 21:39
910e05c
to
8d0610a
Compare
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.