enable spotbugs for CDK core and dependencies submodule #36612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
3 times, most recently
from
ef51c54 to
2692351
Compare
stephane-airbyte
changed the title
gisripa
reviewed
Mar 28, 2024
| @@ -51,10 +51,10 @@ class SshBastionContainer : AutoCloseable { | |||
| } | |||
|
|
|||
| @Throws(IOException::class, InterruptedException::class) | |||
| fun getTunnelMethod(tunnelMethod: SshTunnel.TunnelMethod?, innerAddress: Boolean): JsonNode? { | |||
| fun getTunnelMethod(tunnelMethod: SshTunnel.TunnelMethod, innerAddress: Boolean): JsonNode? { | |||
There was a problem hiding this comment.
Why nullable JsonNode ? does Jsons.jsonNode doesn't guarantee empty JsonNode instead of null ?
There was a problem hiding this comment.
you're right. This is actually reported as a compiler warning. I only focused on the spotbugs in this PR
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
2692351 to
cf29dc8
Compare
This was referenced Mar 29, 2024
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
2 times, most recently
from
c5afa4e to
0911db2
Compare
postamar
approved these changes
Apr 2, 2024
| @@ -33,7 +33,7 @@ import org.testcontainers.containers.PostgreSQLContainer | |||
| import org.testcontainers.utility.MountableFile | |||
|
|
|||
| internal class TestJdbcUtils { | |||
| private var dbName: String? = null | |||
| private var dbName: String = "dummy" | |||
There was a problem hiding this comment.
could this be a legitimate lateinit?
| .stream() | ||
| .findFirst() | ||
| .get() | ||
| .value | ||
| .ipAddress | ||
| ) | ||
| )!! |
There was a problem hiding this comment.
IMO this needs to be addressed as part of this PR.
There was a problem hiding this comment.
suggestion: instead of stream().findFirst()... use kotlin constructs
...cdk/java/airbyte-cdk/dependencies/src/test/kotlin/io/airbyte/workers/TestHarnessUtilsTest.kt
Show resolved
Hide resolved
...java/airbyte-cdk/dependencies/src/testFixtures/kotlin/io/airbyte/workers/TestHarnessUtils.kt
Show resolved
Hide resolved
| if (process != null) { | ||
| TestHarnessUtils.cancelProcess(process) | ||
| } | ||
| process?.let { TestHarnessUtils.cancelProcess(process) } |
There was a problem hiding this comment.
This ? works now that process is lateinit a non-nullable type? Surprising.
| @@ -119,25 +119,24 @@ class DbtTransformationRunner( | |||
| emptyMap(), | |||
| *dbtArguments.toTypedArray<String>() | |||
| ) | |||
| this.process = process | |||
There was a problem hiding this comment.
Why not assign to this.process directly? Evidently there's a reason but for my own information I'd like to understand.
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
4 times, most recently
from
95af1a0 to
d8b4502
Compare
Merge activity
|
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
d8b4502 to
78f46b4
Compare
stephane-airbyte
deleted the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
msaffitz
added a commit
to Encore-Post-Sales/airbyte-magnify
that referenced
this pull request
Apr 3, 2024
* master: (1562 commits) ✨ source-google-drive: migrate to poetry (airbytehq#36581) enable spotbugs for CDK core and dependencies submodule (airbytehq#36612) ✨ Source Salesforce, Shopify: add maxSecondsBetweenMessages in metadata (airbytehq#36723) java-cdk: re-export airbyte-api dependency (airbytehq#36759) Source Google Sheets: address dependency conflict and update CDK (airbytehq#36515) Airbyte CI: rename incorrectly named pipelines (airbytehq#36722) Source Azure Blob Storage: add integration tests (airbytehq#36542) Salesforce: retry on download_data and create_stream_job (airbytehq#36385) ✨Source Monday: Bumped CDK version dependency (airbytehq#36746) airbyte-ci: burst gradle task cache on new java cdk release (airbytehq#36480) chore(connectors): remove tasks.py and top-level requirements.txt (airbytehq#36738) airbyte-ci: fix pull-request-number option for migrate_to_base_image (airbytehq#36779) 🤖 Bump patch version of Python CDK add backward compatibility for an old close slice logic (airbytehq#36774) Bump Airbyte version from 0.57.0 to 0.57.1 🤖 Bump patch version of Python CDK low-code: Fix cursor pagination instantiation if the stop_condition is a string (airbytehq#36760) fix rabbitmq icon and simplify docs registry code (airbytehq#36767) Update azure-entra-id.md (airbytehq#36758) re-enable rabbitmq on OSS (airbytehq#36749) ...
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.