-
Notifications
You must be signed in to change notification settings - Fork 4.5k
source-shopify: ensure inline schemas, updated cdk, poetry (where possible) #36660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChristoGrab
merged 14 commits into
master
from
autopull/schema-descriptions-d2a8da/source-shopify
Apr 30, 2024
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6db8197
schema descriptions
bleonard ccc84fb
schema descriptions
bleonard 468904f
schema descriptions
bleonard 621e074
update changelog
bleonard a522e45
schema descriptions
bleonard bded906
Updating to 0.80.0 CDK
bleonard 48ac6d6
update changelog
bleonard 32e3d88
update
bleonard 80f5957
Merge branch 'master' into autopull/schema-descriptions-d2a8da/source…
3e3d7e2
Bump version
fbbe15a
Incorect place
93c8b61
Remove description
3977bf4
Merge branch 'master' into autopull/schema-descriptions-d2a8da/source…
bleonard ce4cfdb
Merge branch 'master' into autopull/schema-descriptions-d2a8da/source…
bazarnov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",] | |
| build-backend = "poetry.core.masonry.api" | ||
|
|
||
| [tool.poetry] | ||
| version = "2.0.6" | ||
| version = "2.0.7" | ||
| name = "source-shopify" | ||
| description = "Source CDK implementation for Shopify." | ||
| authors = [ "Airbyte <[email protected]>",] | ||
|
|
@@ -17,7 +17,7 @@ include = "source_shopify" | |
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.9,<3.12" | ||
| airbyte-cdk = "^0" | ||
| airbyte-cdk = "0.81.4" | ||
| sgqlc = "==16.3" | ||
| graphql-query = "^1.1.1" | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a change, I understand, but this looks to be better than what's happening with the open pinning. causing less issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual code in use has not changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are no functional changes, i don't think the source bump should take place either, we can safely merge this without source version bump, these changes than be picked up later on with the next functional change (bug fix or improvements).
The cdk version pin will not help us later on when we want to be able to update the sources with the latest functionality causing to bump each and every source again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I also updated all the descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we plan to use these descriptions in UI or elsewhere making this visible for Customers or any kind of functionality for the platform?