source-shopify: ensure inline schemas, updated cdk, poetry (where possible) #36660
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
bleonard
changed the title
| @@ -17,7 +17,7 @@ include = "source_shopify" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9,<3.12" | |||
| airbyte-cdk = "^0" | |||
| airbyte-cdk = "0.81.4" | |||
There was a problem hiding this comment.
This should not be changed.
There was a problem hiding this comment.
It's a change, I understand, but this looks to be better than what's happening with the open pinning. causing less issues.
There was a problem hiding this comment.
The actual code in use has not changed.
There was a problem hiding this comment.
If there are no functional changes, i don't think the source bump should take place either, we can safely merge this without source version bump, these changes than be picked up later on with the next functional change (bug fix or improvements).
The cdk version pin will not help us later on when we want to be able to update the sources with the latest functionality causing to bump each and every source again.
There was a problem hiding this comment.
but I also updated all the descriptions
There was a problem hiding this comment.
do we plan to use these descriptions in UI or elsewhere making this visible for Customers or any kind of functionality for the platform?
|
/format-fix
|
|
The format check issues should be auto-formatted and committed after the |
|
/format-fix
|
ChristoGrab
deleted the
autopull/schema-descriptions-d2a8da/source-shopify
branch
This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:
auto-schema update -s all description: added descriptions to json and inline schemasconnector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifestairbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docsairbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentationairbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) versionThe version number and changelogs were also bumped using the
connector-code pullscommand.