Skip to content

Docs: Update broken links #23940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Docs: Update broken links #23940

merged 5 commits into from
Mar 13, 2023

Conversation

sophia-wiley
Copy link
Contributor

Updating the broken links in docs that are shown in this link check.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 10, 2023
@@ -22,7 +22,7 @@ cd airbyte
```

- In your browser, just visit [http://localhost:8000](http://localhost:8000)
- You will be asked for a username and password. By default, that's username `airbyte` and password `password`. Once you deploy airbyte to your servers, be sure to [change these](/operator-guides/security):
- You will be asked for a username and password. By default, that's username `airbyte` and password `password`. Once you deploy airbyte to your servers, be sure to [change these](https://docs.airbyte.com/operator-guides/security/#network-security):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the link at all since we include the relevant text in this doc

@@ -8,7 +8,7 @@ Airbyte Cloud requires no setup and can be immediately run from your web browser

**1. Using the Airbyte Cloud invite link provided to you, click `Sign up`, and verify your email.**

If you don't have an invite, sign up [here!](https://airbyte.com/cloud-waitlist)
<!-- If you don't have an invite, sign up [here!](https://airbyte.com/cloud-waitlist) -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amruta-Ranade I just commented this link out for historical purposes since this page is not displayed in the sidebar for users anyways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete it


## Performance considerations

SpaceX's [API reference](https://api.spacexdata.com/v5/) has both v4 an v5 for launches. The connector as default uses V4 as it has minimal bugs.
The SpaceX API has both v4 and v5 for [launches](https://github.com/r-spacex/SpaceX-API/tree/master/docs/launches). The connector as default uses V4 as it has minimal bugs.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcosmarxm, I saw that you reviewed the PR for the SpaceX API and I was hoping you could help me with this URL. The URL in the documentation that was originally provided, https://api.spacexdata.com/v5/, seems to be dead and it looks like the website may have been taken down. I was wondering if you think it would be okay to use https://github.com/r-spacex/SpaceX-API/tree/master/docs/launches instead, or if you have any other suggestions for a better URL to point users to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Github link is good. The previous one was only a redirect to Github one though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to know! Thank you

@sophia-wiley sophia-wiley merged commit 76df2f2 into master Mar 13, 2023
@sophia-wiley sophia-wiley deleted the docs_update_broken_links branch March 13, 2023 19:38
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
* updated_links_in_docs

* updated more links

* typo

* removed backticks

* deleted links in deploying on cloud and local deployment
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* updated_links_in_docs

* updated more links

* typo

* removed backticks

* deleted links in deploying on cloud and local deployment
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* updated_links_in_docs

* updated more links

* typo

* removed backticks

* deleted links in deploying on cloud and local deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants