Skip to content

Google Ads: Fix wrong type for metrics.conversations #19030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Google Ads: Fix wrong type for metrics.conversations #19030

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83090bc
Set google analytics conversations type number
Moandco Nov 7, 2022
5f5799c
Merge branch 'master' into fix-google-ads-metrics-conversations-type
Moandco Nov 7, 2022
c9abe4a
Update google ads connector changelog
Moandco Nov 8, 2022
a574701
Merge branch 'fix-google-ads-metrics-conversations-type' of https://g…
Moandco Nov 8, 2022
9b5a3d4
Bump google ads docker version
Moandco Nov 8, 2022
7342afb
Bump disable for version in acceptance-test
Moandco Nov 9, 2022
4ef173d
Ignore discovery test for version 0.2.4
Moandco Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ COPY main.py ./

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.3
LABEL io.airbyte.version=0.2.4
LABEL io.airbyte.name=airbyte/source-google-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/campaigns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
"type": ["null", "number"]
},
"metrics.conversions": {
"type": ["null", "integer"]
"type": ["null", "number"]
},
"metrics.conversions_value": {
"type": ["null", "integer"]
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/google-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Due to a limitation in the Google Ads API which does not allow getting performan

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------------------------------------------------------------|
| `0.2.4` | 2022-11-08 | [19030](https://github.com/airbytehq/airbyte/pull/19030) | Fix data type `metrics.conversions` in`campaigns` stream |
| `0.2.3` | 2022-10-17 | [18069](https://github.com/airbytehq/airbyte/pull/18069) | Add `segments.hour`, `metrics.ctr`, `metrics.conversions` and `metrics.conversions_values` fields to `campaigns` report stream |
| `0.2.2` | 2022-10-21 | [17412](https://github.com/airbytehq/airbyte/pull/17412) | Release with CDK >= 0.2.2 |
| `0.2.1` | 2022-09-29 | [17412](https://github.com/airbytehq/airbyte/pull/17412) | Always use latest CDK version |
Expand Down