-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Google Ads: Fix wrong type for metrics.conversations #19030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Ads: Fix wrong type for metrics.conversations #19030
Conversation
Hi, @Moandco, thanks for the PR. This looks pretty straight forward. Can you:
|
…ithub.com/Moandco/airbyte into fix-google-ads-metrics-conversations-type
Hi @tuanchris, thanks for your review. I updated the changelog and put the unit and integration test output inside the PR description. Not sure where to bump the version of the connector. |
Hi @Moandco, can you follow step 1 & 4 under publishing a connector? |
@tuanchris Thanks for the precise information. I did the bump in the docker file. Right now step 4 fails with that:
The documentation states your action is required. Thanks. |
/test connector=connectors/source-google-ads
Build FailedTest summary info:
|
@tuanchris Thanks for triggering the build. There is one error related to the type change. I don't know what to do about it. Can you help?
|
@Moandco can you bump the version here? |
/test connector=connectors/source-google-ads
Build FailedTest summary info:
|
Test failed with the same error again. 😞 |
The issue was fixed with this PR already. #19208 |
What
Fixes Google ads sync failing during normalization dbt run when Google ads API returns non-integer value for metrics.conversations. Currently the field is expected to be integer, however Google might return floats.
Please refer to the documentation of the field: https://developers.google.com/google-ads/api/fields/v11/metrics#metrics.conversions
How
Change type from
integer
tonumber
in schema json.🚨 User Impact 🚨
No breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.