-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Source S3: Add virtual-hosted-style option #19006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source S3: Add virtual-hosted-style option #19006
Conversation
@Xingyuan-Chen thanks for splitting the source and destination, I’ll take a look. |
/test connector=connectors/source-s3
Build PassedTest summary info:
|
Tests passing, in S3 boto3 client the default is auto for
|
/publish connector=connectors/source-s3
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* add virtual-hosted-style option for S3 source * update s3 version * auto-bump connector version Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
*I add a virtual-hosted-style option for S3 source
*It helps to make S3 source support Non-Amazon S3 endpoint who only support virtual hosted style like Aliyun OSS.
This PR closes #18902