Skip to content

Commit f1dd03b

Browse files
Xingyuan-Chenvincentkococtavia-squidington-iii
authored andcommitted
Source S3: Add virtual-hosted-style option (#19006)
* add virtual-hosted-style option for S3 source * update s3 version * auto-bump connector version Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
1 parent 6257d68 commit f1dd03b

File tree

6 files changed

+6
-4
lines changed

6 files changed

+6
-4
lines changed

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,7 @@
11271127
- name: S3
11281128
sourceDefinitionId: 69589781-7828-43c5-9f63-8925b1c1ccc2
11291129
dockerRepository: airbyte/source-s3
1130-
dockerImageTag: 0.1.25
1130+
dockerImageTag: 0.1.26
11311131
documentationUrl: https://docs.airbyte.com/integrations/sources/s3
11321132
icon: s3.svg
11331133
sourceType: file

airbyte-config/init/src/main/resources/seed/source_specs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10761,7 +10761,7 @@
1076110761
supportsNormalization: false
1076210762
supportsDBT: false
1076310763
supported_destination_sync_modes: []
10764-
- dockerImage: "airbyte/source-s3:0.1.25"
10764+
- dockerImage: "airbyte/source-s3:0.1.26"
1076510765
spec:
1076610766
documentationUrl: "https://docs.airbyte.com/integrations/sources/s3"
1076710767
changelogUrl: "https://docs.airbyte.com/integrations/sources/s3"

airbyte-integrations/connectors/source-s3/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ COPY source_s3 ./source_s3
1717
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
1818
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1919

20-
LABEL io.airbyte.version=0.1.25
20+
LABEL io.airbyte.version=0.1.26
2121
LABEL io.airbyte.name=airbyte/source-s3

airbyte-integrations/connectors/source-s3/integration_tests/config_minio.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"aws_access_key_id": "123456",
77
"aws_secret_access_key": "123456key",
88
"path_prefix": "",
9-
"endpoint": "http://10.0.56.135:9000"
9+
"endpoint": "http://10.0.229.255:9000"
1010
},
1111
"format": {
1212
"filetype": "csv"

airbyte-integrations/connectors/source-s3/source_s3/s3_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ def _get_s3_client_args(provider: dict, config: Config) -> dict:
4848
client_kv_args["endpoint_url"] = endpoint
4949
client_kv_args["use_ssl"] = provider.get("use_ssl", True)
5050
client_kv_args["verify"] = provider.get("verify_ssl_cert", True)
51+
client_kv_args["config"] = Config(s3={"addressing_style": provider.get("addressing_style", "auto")})
5152

5253
return client_kv_args
5354

docs/integrations/sources/s3.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ The Jsonl parser uses pyarrow hence,only the line-delimited JSON format is suppo
205205
206206
| Version | Date | Pull Request | Subject |
207207
|:--------|:-----------|:----------------------------------------------------------------------------------------------------------------|:----------------------------------------------------------------------------------------|
208+
| 0.1.26 | 2022-11-08 | [19006](https://github.com/airbytehq/airbyte/pull/19006) | Add virtual-hosted-style option |
208209
| 0.1.24 | 2022-10-28 | [18602](https://github.com/airbytehq/airbyte/pull/18602) | Wrap errors into AirbyteTracedException pointing to a problem file |
209210
| 0.1.23 | 2022-10-10 | [17991](https://github.com/airbytehq/airbyte/pull/17991) | Fix pyarrow to JSON schema type conversion for arrays |
210211
| 0.1.23 | 2022-10-10 | [17800](https://github.com/airbytehq/airbyte/pull/17800) | Deleted `use_ssl` and `verify_ssl_cert` flags and hardcoded to `True` |

0 commit comments

Comments
 (0)