Skip to content

Salesforce best practices #1562 #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 21, 2021
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "2470e835-feaf-4db6-96f3-70fd645acc77",
"name": "Salesforce",
"dockerRepository": "airbyte/source-salesforce-singer",
"dockerImageTag": "0.1.5",
"dockerImageTag": "0.1.6",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-salesforce-singer"
}
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
- sourceDefinitionId: 2470e835-feaf-4db6-96f3-70fd645acc77
name: Salesforce
dockerRepository: airbyte/source-salesforce-singer
dockerImageTag: 0.1.5
dockerImageTag: 0.1.6
documentationUrl: https://hub.docker.com/r/airbyte/source-salesforce-singer
- sourceDefinitionId: e094cb9a-26de-4645-8761-65c0c425d1de
name: Stripe
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ def set_sync_modes_from_metadata(airbyte_stream: AirbyteStream, metadatas: List[
if forced_replication_method.upper() == _INCREMENTAL:
airbyte_stream.source_defined_cursor = True
airbyte_stream.supported_sync_modes = [SyncMode.incremental]
elif forced_replication_method.upper() == _FULL_TABLE:
airbyte_stream.source_defined_cursor = False
airbyte_stream.supported_sync_modes = [SyncMode.full_refresh]


def override_sync_modes(airbyte_stream: AirbyteStream, overrides: SyncModeInfo):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@
SOFTWARE.
"""


def test_example_method():
assert True
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@
SOFTWARE.
"""


def test_example_method():
assert True
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@
SOFTWARE.
"""


def test_example_method():
assert True
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@
SOFTWARE.
"""


def test_example_method():
assert True
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ENV CODE_PATH="source_salesforce_singer"
ENV AIRBYTE_IMPL_MODULE="source_salesforce_singer"
ENV AIRBYTE_IMPL_PATH="SourceSalesforceSinger"

LABEL io.airbyte.version=0.1.5
LABEL io.airbyte.version=0.1.6
LABEL io.airbyte.name=airbyte/source-salesforce-singer

WORKDIR /airbyte/integration_code
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
id 'airbyte-docker'
id 'airbyte-integration-test-java'
id 'airbyte-python'
// id 'airbyte-standard-source-test-file'
}

airbytePython {
Expand All @@ -10,11 +10,19 @@ airbytePython {

// We cannot run standard source tests with every build because it blows through the Salesforce quota. For now, turn this on as needed and run these tests locally; they will not be run in CI.
// CRITICAL Salesforce has reported 13060/15000 (87.07%) total REST quota used across all Salesforce Applications. Terminating replication to not continue past configured percentage of 80% total quota.
// imageName = "${extractImageName(project.file('Dockerfile'))}:dev"
// specPath = 'source_salesforce_singer/spec.json'
// configPath ='secrets/config.json'
// catalogPath = 'standard_test/catalog.json'
//airbyteStandardSourceTestFile {
// // For more information on standard source tests, see https://docs.airbyte.io/contributing-to-airbyte/building-new-connector/testing-connectors
// // All these input paths must live inside this connector's directory (or subdirectories)
// specPath = "source_salesforce_singer/spec.json"
// // configPath points to a config file which matches the spec.json supplied above. secrets/ is gitignored by default, so place your config file
// // there (in case it contains any credentials)
// configPath = "secrets/config.json"
// // Note: If your source supports incremental syncing, then make sure that the catalog that is returned in the get_catalog method is configured
// // for incremental syncing (e.g. include cursor fields, etc).
// configuredCatalogPath = "sample_files/configured_catalog.json"
//}

dependencies {
implementation files(project(':airbyte-integrations:bases:base-singer').airbyteDocker.outputs)
}

Loading