Skip to content

Salesforce best practices #1562 #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 21, 2021

Conversation

vitaliizazmic
Copy link
Contributor

What

Apply connector best practices for Salesforce source

How

  1. Checking obtaining tokens
  2. Checking connection failure
  3. Checking syncing for every stream
  4. Checking handling rate limits. Tap-salesforce backs off on hitting
  5. Checking incremental sync

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Jan 14, 2021

/test connector=source-salesforce-singer

🕑 source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/486324226
✅ source-salesforce-singer https://github.com/airbytehq/airbyte/actions/runs/486324226

@sherifnada
Copy link
Contributor

@vitaliizazmic i'm not seeing any changes related to error handling -- have you verified that those look good on your end?

@vitaliizazmic
Copy link
Contributor Author

@sherifnada I've checked tap-salesforce. It handles errors
https://github.com/singer-io/tap-salesforce/blob/cd3cd9d020b6171276aa798199acb931709f5ddb/tap_salesforce/salesforce/rest.py#L23

@sherifnada sherifnada merged commit 46881ce into master Jan 21, 2021
@sherifnada sherifnada deleted the vitalii/1562_salesforce_best_practices branch January 21, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants