Skip to content

Helm chart: add Kubernetes Auth options, fix k8s job tolerations #12236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Helm chart: add Kubernetes Auth options, fix k8s job tolerations #12236

wants to merge 1 commit into from

Conversation

ufou
Copy link
Contributor

@ufou ufou commented Apr 21, 2022

What

  • Adds kubernetes authentication options:
    • use kube config inside pod
    • use service account/token inside pod
  • Fix kube job tolerations

How

Add 2 new ENV vars:

  • KUBERNETES_AUTH_TRYKUBECONFIG
  • KUBERNETES_AUTH_TRYSERVICEACCOUNT
    If either is set to true then the pod will try to use the authentication method against kubernetes, afaik this is only worker and pod_sweeper

Fix kube job tolerations by making sure the JOB_KUBE_TOLERATIONS env var gets created via a list of maps (template helper functions takes care of this)

Recommended reading order

🚨 User Impact 🚨

There should be no braking changes from the existing helm chart behaviour, the defaults are as they were

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Apr 21, 2022
@alafanechere alafanechere self-assigned this Apr 25, 2022
@alafanechere alafanechere changed the title add helm chart Kubernetes Auth options, fix k8s job tolerations Helm chart: add Kubernetes Auth options, fix k8s job tolerations Apr 25, 2022
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ufou, thank you for this effort!
Your PR touches two different topics: K8S auth and job toleration.
Could you please open one PR for each of these changes to make the PR atomic?
Could you also please create issues linked to these PRs to explain why you are doing these changes. The issues will be the right place for our infra team to check if it does not overlap with ongoing internal work. (This is explained in our contribution guidelines here)

@ufou
Copy link
Contributor Author

ufou commented Apr 25, 2022

Closing in favour of #12314 and #12312

@ufou ufou closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants