Skip to content

helm chart: JOB_KUBE_TOLERATIONS bad formatting #12312

Closed
@ufou

Description

@ufou

Environment

  • Airbyte version: 0.36.1-alpha
  • OS Version / Instance: k8s 1.20
  • Deployment: Kubernetes deploy env
  • Source Connector and version: n/a
  • Destination Connector and version: n/a
  • Severity: Low
  • Step where error happened: Deploy

Current Behavior

If kube job tolerations are set via values the helm chart, the deployed ENV var for JOB_KUBE_TOLERATIONS will at best be malformed and at worst be invalid and cause jobs to fail

Expected Behavior

JOB_KUBE_TOLERATIONS to be valid and parsed as by the job to add the correct tolerations to the pod

Logs

n/a

Steps to Reproduce

  1. I introduced this functionality in a previous PR but did not correctly identify that tolerations is an array of maps, rather than a map (like nodeSelector)

Are you willing to submit a PR?

Yes, incoming

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions