Skip to content

helm chart: JOB_KUBE_TOLERATIONS bad formatting #12312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ufou opened this issue Apr 25, 2022 · 2 comments
Closed

helm chart: JOB_KUBE_TOLERATIONS bad formatting #12312

ufou opened this issue Apr 25, 2022 · 2 comments
Labels
area/platform issues related to the platform community helm kubernetes team/platform-move type/bug Something isn't working

Comments

@ufou
Copy link
Contributor

ufou commented Apr 25, 2022

Environment

  • Airbyte version: 0.36.1-alpha
  • OS Version / Instance: k8s 1.20
  • Deployment: Kubernetes deploy env
  • Source Connector and version: n/a
  • Destination Connector and version: n/a
  • Severity: Low
  • Step where error happened: Deploy

Current Behavior

If kube job tolerations are set via values the helm chart, the deployed ENV var for JOB_KUBE_TOLERATIONS will at best be malformed and at worst be invalid and cause jobs to fail

Expected Behavior

JOB_KUBE_TOLERATIONS to be valid and parsed as by the job to add the correct tolerations to the pod

Logs

n/a

Steps to Reproduce

  1. I introduced this functionality in a previous PR but did not correctly identify that tolerations is an array of maps, rather than a map (like nodeSelector)

Are you willing to submit a PR?

Yes, incoming

@marcosmarxm
Copy link
Member

@ufou can you update here #12236 to remove this code from there?

@ufou
Copy link
Contributor Author

ufou commented Jun 30, 2022

obsolete issue, fixed in a different issue/pr

@ufou ufou closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community helm kubernetes team/platform-move type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants