Skip to content

🐛 octavia-cli: update readme #11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2022
Merged

🐛 octavia-cli: update readme #11002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
240d43b
fix 2.b
alafanechere Mar 9, 2022
396cc6f
fix 2.b
alafanechere Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion octavia-cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ This script:

## 2.b If you want to directly run the CLI without alias in your current directory:
```bash
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev
mkdir my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored.
mkdir -p my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored.

I think the flag -p is useful 📦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no subdir in this example so no need to create directories recursively IMO, wdyt? 🤔

docker run --rm -v ./my_octavia_project_directory:/home/octavia-project --network host -e AIRBYTE_URL="http://localhost:8000" airbyte/octavia-cli:dev
````

# Current development status
Expand Down