🐛 octavia-cli: update readme #11002
Merged
🐛 octavia-cli: update readme #11002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
added
area/documentation
github-actions
bot
removed
the
area/documentation
marcosmarxm
reviewed
Mar 9, 2022
| @@ -26,7 +26,8 @@ This script: | |||
|
|
|||
| ## 2.b If you want to directly run the CLI without alias in your current directory: | |||
| ```bash | |||
| docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev | |||
| mkdir my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored. | |||
There was a problem hiding this comment.
Suggested change
| mkdir my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored. | |
| mkdir -p my_octavia_project_directory # Create your octavia project directory where YAML configurations will be stored. |
I think the flag -p is useful 📦
There was a problem hiding this comment.
There's no subdir in this example so no need to create directories recursively IMO, wdyt? 🤔
marcosmarxm
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
docker runcommand more easily readable for users.