Skip to content

Add a maximum page size and use the count instead of the list #10443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Add a maximum page size and use the count instead of the list #10443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b654c67
Add a maximum page size and use the count instead of the list
benmoriceau Feb 17, 2022
938af98
Fix typo
benmoriceau Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions airbyte-workers/src/main/java/io/airbyte/workers/temporal/TemporalClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import io.airbyte.workers.temporal.scheduling.state.WorkflowState;
import io.airbyte.workers.temporal.spec.SpecWorkflow;
import io.airbyte.workers.temporal.sync.SyncWorkflow;
import io.temporal.api.workflow.v1.WorkflowExecutionInfo;
import io.temporal.api.workflowservice.v1.ListOpenWorkflowExecutionsRequest;
import io.temporal.api.workflowservice.v1.ListOpenWorkflowExecutionsResponse;
import io.temporal.client.BatchRequest;
Expand All @@ -40,7 +39,6 @@
import java.io.IOException;
import java.nio.file.Path;
import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.UUID;
Expand All @@ -65,6 +63,8 @@ public class TemporalClient {
*/
private static final int DELAY_BETWEEN_QUERY_MS = 10;

private static final int MAXIMUM_SEARCH_PAGE_SIZE = 50;

public static TemporalClient production(final String temporalHost, final Path workspaceRoot, final Configs configs) {
final WorkflowServiceStubs temporalService = TemporalUtils.createTemporalService(temporalHost);
return new TemporalClient(WorkflowClient.newInstance(temporalService), workspaceRoot, temporalService, configs);
Expand Down Expand Up @@ -454,14 +454,15 @@ public boolean isWorkflowRunning(final String workflowName) {
ListOpenWorkflowExecutionsRequest openWorkflowExecutionsRequest =
ListOpenWorkflowExecutionsRequest.newBuilder()
.setNamespace(client.getOptions().getNamespace())
.setMaximumPageSize(MAXIMUM_SEARCH_PAGE_SIZE)
.build();
do {
final ListOpenWorkflowExecutionsResponse listOpenWorkflowExecutionsRequest =
service.blockingStub().listOpenWorkflowExecutions(openWorkflowExecutionsRequest);
final List<WorkflowExecutionInfo> workflowExecutionInfos = listOpenWorkflowExecutionsRequest.getExecutionsList().stream()
final long matchingWorkflowCount = listOpenWorkflowExecutionsRequest.getExecutionsList().stream()
.filter((workflowExecutionInfo -> workflowExecutionInfo.getExecution().getWorkflowId().equals(workflowName)))
.collect(Collectors.toList());
if (!workflowExecutionInfos.isEmpty()) {
.count();
if (matchingWorkflowCount != 0) {
return true;
}
token = listOpenWorkflowExecutionsRequest.getNextPageToken();
Expand All @@ -470,6 +471,7 @@ public boolean isWorkflowRunning(final String workflowName) {
ListOpenWorkflowExecutionsRequest.newBuilder()
.setNamespace(client.getOptions().getNamespace())
.setNextPageToken(token)
.setMaximumPageSize(MAXIMUM_SEARCH_PAGE_SIZE)
.build();

} while (token != null && token.size() > 0);
Expand Down