Add a maximum page size and use the count instead of the list #10443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
pmossman
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Approved other than small typo. Looking at the rest of the TemporalClient class, we use a similar pagination strategy here: https://github.com/airbytehq/airbyte/pull/10443/files#diff-391d9b999892f837218e35e29b9c6cf48e5b6316b6f3fc89791601c213931b0aL188-L212
But it looks like there we need to keep everything in memory. Will that method be used just for migrating OSS to the new scheduler? In that case it shouldn't pose a problem
| .build(); | ||
| do { | ||
| final ListOpenWorkflowExecutionsResponse listOpenWorkflowExecutionsRequest = | ||
| service.blockingStub().listOpenWorkflowExecutions(openWorkflowExecutionsRequest); | ||
| final List<WorkflowExecutionInfo> workflowExecutionInfos = listOpenWorkflowExecutionsRequest.getExecutionsList().stream() | ||
| final long matchingWorkflowCoumt = listOpenWorkflowExecutionsRequest.getExecutionsList().stream() |
There was a problem hiding this comment.
typo, matchingWorkflowCoumt -> matchingWorkflowCount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a page size and avoid storing the list result.