Skip to content

Fix failing sonar-scan without changes #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Fix failing sonar-scan without changes #10278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/sonar-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ jobs:
echo "::set-output name=changed-modules::{ \"include\": $CHANGES }"

run-ci-tests:
if: github.event.pull_request.draft == false
# Do only run if the PR is not a draft and the changed modules matrix contains at least one entry
if: github.event.pull_request.draft == false && fromJson(needs.detect-changes.outputs.changed-modules).include[0] != null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Unfortunately GitHub expressions syntax doesn't support any form of length. This seems to be the best way to check if the array has at least one element.

needs: detect-changes
name: Tests for ${{ matrix.module }}
runs-on: ubuntu-latest
Expand Down