Fix failing sonar-scan without changes #10278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
commented
Feb 11, 2022
| @@ -36,7 +36,8 @@ jobs: | |||
| echo "::set-output name=changed-modules::{ \"include\": $CHANGES }" | |||
|
|
|||
| run-ci-tests: | |||
| if: github.event.pull_request.draft == false | |||
| # Do only run if the PR is not a draft and the changed modules matrix contains at least one entry | |||
| if: github.event.pull_request.draft == false && fromJson(needs.detect-changes.outputs.changed-modules).include[0] != null | |||
There was a problem hiding this comment.
ℹ️ Unfortunately GitHub expressions syntax doesn't support any form of length. This seems to be the best way to check if the array has at least one element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Do not try to run the sonar-check if we don't have a matrix determined. This will currently fail (see e.g. https://github.com/airbytehq/airbyte/actions/runs/1830326733) and send notifications out for that failure. We should simply never try to run this if a PR doesn't change anything in a module requiring a sonar-scan.
See https://github.com/airbytehq/airbyte/actions/runs/1830360752 for an example run (on this PR) where this was now successfully skipped.