refactor: install opts after cluster creation #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perangel
approved these changes
Jul 2, 2025
colesnodgrass
approved these changes
Jul 2, 2025
Base automatically changed from
bernielomax/refactor/move-parse-volume-mounts
to
main
July 2, 2025 21:54
The extra volume mounts field was not actually used as an install option; it is only needed during cluster provisioning. Removing it from the install options allows us to move the initialization of install options further down the code path, after cluster creation. This enables actions such as querying Helm or the cluster when constructing Helm values, etc.
We should be able to query the cluster and Helm when initializing values now.
fixes var names that are returned to improve readability.
bernielomax
force-pushed
the
bernielomax/refactor/install-opts-after-cluster-creation
branch
from
7ab2a49 to
fa7cc83
Compare
bernielomax
deleted the
bernielomax/refactor/install-opts-after-cluster-creation
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves InstallOpts initialization to after cluster creation. Now we should be able to establish a Helm client and fetch chart details to assist with feature releases whilst providing backwards compatibility in future.
The last commit is not really relevant. Just some tidy up.
This PR follows - #169