chore: move ParseVolumeMounts to the k8s package #169
Merged
+92
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is more k8s-related since it returns a k8s.ExtraVolumeMount slice that is only used by the k8s package. Moving it also helps reduce the footprint of the local install package. My intention is to later break up "install options" and "infra options". This will mean that we can do more powerful querying against Helm when computing Helm values, etc. Obviously this needs to happen after infra has been provisioned. Separating the options helps us to do that. Meaning we can move the computing of install options further down the install code path.
perangel
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is more k8s-related since it returns a k8s.ExtraVolumeMount slice that is only used by the k8s package. Moving it also helps reduce the footprint of the local install package.
My intention is to later break up "install options" and "infra options". This will mean that we can do more powerful querying against Helm when computing Helm values, etc. Obviously this needs to happen after infra has been provisioned. Separating the options helps us to do that. Meaning we can move the computing of install options further down the install code path.