-
-
Notifications
You must be signed in to change notification settings - Fork 322
Fix for Locale matching in jdk24 #6049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @psawant19 please make sure you sign the ECA (details here: https://adoptium.net/docs/eca-sign-off/) |
a2af357
to
06acc79
Compare
@llxia , This is a probable fix for locale. |
|
9fee889
to
77da7cf
Compare
All test cases passed. Please find below the results.
|
Added an extended mapping for chinese - zh-Latn-CN Signed-off-by: Pratiksha Sawant <[email protected]>
77da7cf
to
147b650
Compare
Code changes made in LocaleFilterTest*_16.properties fixes the issues in jdk24, but fails in jdk21. |
Thanks @psawant19 . If this PR fails in JDK21, we cannot merge it. Please create new property files for JDK24+. |
Fixed properties files as we need to have 2 different files one for 16+ and 24+ jdk versions. Signed-off-by: Pratiksha Sawant <[email protected]>
I have fixed the properties files as we need to have 2 different files one for 16+ and 24+ jdk versions. Below are the test results for jdk17, jdk21 and jdk24 versions. https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/49826/ -> JDK17 |
@psawant19 could you cherry-pick the PR into https://github.com/adoptium/aqa-tests/tree/v1.0.7-release? Thanks |
As per the openJDK release notes for JDK 24 (See : https://jdk.java.net/24/release-notes) CLDR was updated to version 46, which introduced a defaultContent mapping for Chinese (Latin, China) — zh_Latn_CN.
This commit has been done to:
References:-
https://www.oracle.com/java/technologies/javase/24-relnote-issues.html
https://cldr.unicode.org/downloads/cldr-46
Signed-off-by: Pratiksha Sawant [email protected]