[pull] master from prebid:master #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Reinstate test block from #13397
Co-authored-by: vrishko <[email protected]>
…url (#13399) - Replaced deprecated `userId` field with ORTB2-compliant `userIdAsEids` via `bidderRequest.userIdAsEids` - Enhanced user ID mapping to match ResetDigital backend format (e.g. nested ID structures like uid2, lipb, etc.) - Removed usage of `transactionId` for `imp_id` as per #9781; replaced with `bidId` - Fixed incorrect access to `refererInfo.stack` (previously outputting an array with `[stack.length - 1]`) - Maintained backward compatibility with expected payload structure by the ResetDigital bidding endpoint Related to: - #11377 (remove deprecated bidderRequest.userId) - #9781 (avoid leaking transactionId) Co-authored-by: Chris Huie <[email protected]>
* Expand AGENTS guidelines * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Update AGENTS.md * Create CLAUDE.md * Update AGENTS.md * core: persist babel cache
* FreepassBidAdaptor & IdSystem: use userIdAsEids rather than br.{}.userId
* freepass: change source to freepass.jp
* freepass: shouldn't return fallback
---------
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Patrick McCann <[email protected]>
This reverts commit 125b917. Co-authored-by: Patrick McCann <[email protected]>
…size in imp (#13434) Added code changes to remove empty format array when there is single size in imp
Co-authored-by: Komal Kumari <[email protected]>
* chore: Updated adapter to use userIdAsEids instead of userId * fix: specify our eids
* Big Bidmatic update * Big Bidmatic update * Bidmatic bidfloor integration * Add view parts * Fix testing
* Add floor pricing for bid requests * Set USD instead of CHF for currency * Wrong name * Add floor test
* Refactored the init function * Added new line for linting error * removed the listener before firing the handler * Removed event listener when module is disabled --------- Co-authored-by: pm-azhar-mulla <[email protected]>
…Sharethrough Bid Adapter: add parameter to activate test endpoint (#13431) * add support of dsa * restore topics * DSA fix for UT * drafy of adapter * fixes after dev test * make world simpler * fix prev commit * return empty userSyncs array by default * adjustments * apply prettier * unit tests for Equativ adapter * add dsp user sync * add readme * body can be undef * support additional br params * remove user sync * do not send dt param * handle floors and network id * handle empty media types * get min floor * fix desc for u.t. * better name for u.t. * add u.t. for not supported media type * improve currency u.t. * updates after pr review * SADR-6484: initial video setup for new PBJS adapter * SADR-6484: Adding logging requirement missed earlier * SADR-6484: handle ext.rewarded prop for video with new oRTBConverter * SADR-6484: test revision + not sending bid requests where video obj is empty * refactoring and u.t. * rename variable * Equativ: SADR-6615: adding unit tests for and additional logging to bid adapter to support native requests * revert changes rel. to test endpoint * revert changes rel. to test endpoint * split imp[0] into seperate requests and fix u.t. * Equativ bid adapter: adding support for native media type * Equativ bid adapter: update unit test for native-support work * Equativ bid adapter: removing console.log from unit test file * Equativ bid adapter: clarifying refinements regarding native-request processing * Equativ Bid Adapter: updating unit tests for native requests * PR feedback * Equativ Bid Adapter: add audio-specific warnings for missing fields in bid requests * split imp per floor * restore imp id * banner media type may be not set * adapt unit test * remove unnecessary if statement, adapt unit test * remove unnecessary if statement * stx calling eqt endpoint * restore cleanObject logic; fix and add unit tests for multi imp * readd comma * fix linter issues + add unit tests * remove getBidFloor tests * dsp user sync * enable previous auction info * remove logs * send previous auction info * read exp * remove enablePreviousAuctionInfo library * set default ttl in converter config * fix linter * revert test changes * add publisherId param to test eqt endpoint * remove new line * fixes after dev test * Add unit tests * Comment test data. Fix linter issues * Remove test data. Move duplicated code * Fix linter issue * Update calledId * Fix native test * Restore getUserSync. Add UT for equativUtils.js * add prebid version to the request parameters * test update * add renderer * improve u.t. * remove test data * change optional param name * update of u.t * remove empty line * remove semicolon --------- Co-authored-by: Elżbieta SZPONDER <[email protected]> Co-authored-by: eszponder <[email protected]> Co-authored-by: janzych-smart <[email protected]> Co-authored-by: Jeff Mahoney <[email protected]> Co-authored-by: Jeff Mahoney <[email protected]> Co-authored-by: janzych-smart <[email protected]> Co-authored-by: Krzysztof SIEG <[email protected]> Co-authored-by: Elżbieta SZPONDER <[email protected]>
* remove preflight request from greenbids RTD module * bump version
* rubiconBidAdapter: remove default bid limit fallback in bid request * rubiconBidAdapter: maintain reference ordering consistency in buildRequests
…ig present. (#13440) * Renamed pbv to dmv and added dm in both logger and tracker * Revert "Renamed pbv to dmv and added dm in both logger and tracker" This reverts commit 1292db1. * get s2sConfig returns undefined when no server side bidders are added. * combine if conditions and use optional chaining * Update pubmaticAnalyticsAdapter.js
Co-authored-by: Chris Huie <[email protected]>
* Core: Error Detection for Autoplay Detection Avoids errors when videoElement.play() does not return a Promise. Closes #12951 * test: add autoplayDetection no-promise test (#13337) * Update autoplayDetection_spec.js * Update autoplayDetection_spec.js --------- Co-authored-by: Patrick McCann <[email protected]>
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
this is already in the 10 branch, still fails in master
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
* Zeta SSP Adapter: add GPP support. * Zeta SSP Adapter: tests for GPP. * Update zeta_global_sspBidAdapter.js --------- Co-authored-by: Patrick McCann <[email protected]>
* Enhance Babel configuration to support ES5 output - Added support for an ES5 mode in babelConfig.js, allowing for transpilation to ES5 syntax when the `--ES5` flag is used. - Updated gulpfile.js and webpack.conf.js to pass the ES5 flag and adjust module handling accordingly. - Enhanced README.md to document the new ES5 output feature and its usage. This change improves compatibility with older browsers and environments requiring ES5 syntax. * Update Babel configuration to conditionally use 'usage' for built-ins in ES5 mode --------- Co-authored-by: Abdullah Cicekli <[email protected]>
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
…data (#13682) * OMS Bid Adapter: add usp and update gdpr fields structure in request data, update tests * remove code duplication in getMinSize func for oms, onomagic, 33across, marsmedia and medianet adapters * remove code duplication in getBidFloor func for oms and onomagic adapters * remove code duplication in isIframe func for oms, onomagic, 33across, valuad and underdogmedia adapters
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
* Core: extend webdriver session timeouts * Update wdio.shared.conf.js
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
* Supporting IAS & IM rtd keys * Fixed linting error
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
* test: clear native timers * Modules: clear native timers in tests * Tests: restore fake timers to remove sinon warnings
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
… settings (#13708) * Fixed schains field population from bidder settings * updated tests to the new data path
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
* ixBidAdapter: avoid looping over all properties of the array Switch to an indexed for loop instead of a for...in loop to loop over the values contained in the array. Otherwise other properties of the array might be picked up, for example when somebody has adjusted the array prototype to for example add an average function on it. * Switch from indexed for loop to for...of
|
Tread carefully! This PR adds 16 linter errors (possibly disabled through directives):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )