Skip to content

Commit 125b917

Browse files
Gulpfile: eliminate gulp connect dependency (#13284)
* core: remove gulp-connect server * update package-lock * Update package-lock.json * Update package-lock.json --------- Co-authored-by: Chris Huie <[email protected]>
1 parent 7d8960c commit 125b917

File tree

4 files changed

+19
-770
lines changed

4 files changed

+19
-770
lines changed

gulpfile.js

Lines changed: 14 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ var argv = require('yargs').argv;
66
var gulp = require('gulp');
77
var PluginError = require('plugin-error');
88
var fancyLog = require('fancy-log');
9-
var connect = require('gulp-connect');
9+
var express = require('express');
10+
var http = require('http');
1011
var webpack = require('webpack');
1112
var webpackStream = require('webpack-stream');
1213
var gulpClean = require('gulp-clean');
@@ -101,12 +102,9 @@ function viewCoverage(done) {
101102
var coveragePort = 1999;
102103
var mylocalhost = (argv.host) ? argv.host : 'localhost';
103104

104-
connect.server({
105-
port: coveragePort,
106-
root: 'build/coverage/lcov-report',
107-
livereload: false,
108-
debug: true
109-
});
105+
const app = express();
106+
app.use(express.static('build/coverage/lcov-report'));
107+
http.createServer(app).listen(coveragePort);
110108
opens('http://' + mylocalhost + ':' + coveragePort);
111109
done();
112110
};
@@ -173,8 +171,7 @@ function makeDevpackPkg(config = webpackConfig) {
173171
.forEach((use) => use.options = Object.assign({}, use.options, babelConfig));
174172

175173
return prebidSource(cloned)
176-
.pipe(gulp.dest('build/dev'))
177-
.pipe(connect.reload());
174+
.pipe(gulp.dest('build/dev'));
178175
}
179176
}
180177

@@ -480,28 +477,17 @@ function startIntegServer(dev = false) {
480477
}
481478

482479
function startLocalServer(options = {}) {
483-
connect.server({
484-
https: argv.https,
485-
port: port,
486-
host: INTEG_SERVER_HOST,
487-
root: './',
488-
livereload: options.livereload,
489-
middleware: function () {
490-
return [
491-
function (req, res, next) {
492-
res.setHeader('Ad-Auction-Allowed', 'True');
493-
next();
494-
}
495-
];
496-
}
480+
const app = express();
481+
app.use(function (req, res, next) {
482+
res.setHeader('Ad-Auction-Allowed', 'True');
483+
next();
497484
});
485+
app.use(express.static('./'));
486+
http.createServer(app).listen(port, INTEG_SERVER_HOST);
498487
}
499488

500489
// Watch Task with Live Reload
501490
function watchTaskMaker(options = {}) {
502-
if (options.livereload == null) {
503-
options.livereload = true;
504-
}
505491
options.alsoWatch = options.alsoWatch || [];
506492

507493
return function watch(done) {
@@ -513,15 +499,15 @@ function watchTaskMaker(options = {}) {
513499
'modules/**/*.js',
514500
].concat(options.alsoWatch));
515501

516-
startLocalServer(options);
502+
startLocalServer();
517503

518504
mainWatcher.on('all', options.task());
519505
done();
520506
}
521507
}
522508

523509
const watch = watchTaskMaker({alsoWatch: ['test/**/*.js'], task: () => gulp.series(clean, gulp.parallel(lint, 'build-bundle-dev', test))});
524-
const watchFast = watchTaskMaker({livereload: false, task: () => gulp.series('build-bundle-dev')});
510+
const watchFast = watchTaskMaker({task: () => gulp.series('build-bundle-dev')});
525511

526512
// support tasks
527513
gulp.task(lint);

integrationExamples/gpt/amp/gulpfile.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@
44
*/
55

66
var gulp = require('gulp');
7-
var connect = require('gulp-connect');
7+
var express = require('express');
8+
var http = require('http');
89
var port = 5000;
910

1011
gulp.task('serve', function() {
11-
connect.server({
12-
port: port,
13-
root: './',
14-
livereload: true,
15-
https: true
16-
});
12+
var app = express();
13+
app.use(express.static('./'));
14+
http.createServer(app).listen(port);
1715
});

0 commit comments

Comments
 (0)