Skip to content

[macOS] Add Xcode 16.4 to macOS-15 images #12281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

erik-bershel
Copy link
Contributor

Description

  • Add Xcode 16.4
  • Decrease free space on runner to fit new Xcode (30GB -> 25GB)

Related issue:

#12167

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 16:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Xcode 16.4 to macOS-15 images and updates the disk free space requirement from 30GB to 25GB to accommodate the larger Xcode installation.

  • Added new Xcode 16.4 entries to both x64 and arm64 sections in the toolset file
  • Updated runtime installation parameters for Xcode 16.3 entries
  • Modified the disk free space check in tests to reflect the new 25GB minimum

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
images/macos/toolsets/toolset-15.json Added Xcode 16.4 entries and updated runtime settings
images/macos/scripts/tests/System.Tests.ps1 Adjusted disk space check to use a 25GB minimum
Comments suppressed due to low confidence (2)

images/macos/toolsets/toolset-15.json:20

  • Changing 'install_runtimes' from an array to a string value for the Xcode 16.3 entry may affect downstream code expecting an array; please confirm that this change is compatible with the installation logic.
"install_runtimes": "none"

images/macos/toolsets/toolset-15.json:60

  • Changing 'install_runtimes' from an array to a string value for the Xcode 16.3 entry in the arm64 block may lead to compatibility issues if the consuming logic expects an array; verify the new value is handled correctly.
"install_runtimes": "none"

@ijunaidm1 ijunaidm1 merged commit be725e1 into actions:main May 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants