-
Notifications
You must be signed in to change notification settings - Fork 24
Add support for thread messages #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,7 @@ | |
require 'spec_helper' | ||
|
||
describe RocketChat::Room do | ||
pending 'Add some specs for RocketChat::Room' | ||
it 'RocketChat::Room spec', pending: 'Add some specs for RocketChat::Room' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why you've changed this? If it's for linter reasons, the previous form was just fine?! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, RSpec/PendingWithoutReason was raised. Rubocop in actions is not using rubocop.yml from project root, and pipeline was failing because of these two issues I've updated in this PR. All was good when I run rubocop locally |
||
raise NotImplementedError, 'Add some specs for RocketChat::Room' | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although I get why the lint exists, in the this case it's not really an issue. I've already "fixed" this by just allowing up to 2 indexed let variables. But this is fine too