Add support for thread messages #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrom
approved these changes
Apr 20, 2023
| @@ -104,14 +104,14 @@ | |||
| end | |||
|
|
|||
| describe '#list_all' do | |||
| let(:room1) do | |||
| let(:room_one) do | |||
There was a problem hiding this comment.
although I get why the lint exists, in the this case it's not really an issue. I've already "fixed" this by just allowing up to 2 indexed let variables. But this is fine too
| @@ -3,5 +3,7 @@ | |||
| require 'spec_helper' | |||
|
|
|||
| describe RocketChat::Room do | |||
| pending 'Add some specs for RocketChat::Room' | |||
| it 'RocketChat::Room spec', pending: 'Add some specs for RocketChat::Room' do | |||
There was a problem hiding this comment.
Not sure why you've changed this? If it's for linter reasons, the previous form was just fine?!
There was a problem hiding this comment.
Yes, RSpec/PendingWithoutReason was raised. Rubocop in actions is not using rubocop.yml from project root, and pipeline was failing because of these two issues I've updated in this PR. All was good when I run rubocop locally
|
Released in v0.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmidcould be used to send message to specific threadsession.chat.post_message(room_id: 'channel_id', tmid: 'message_id', text: 'text')