fix: Improve detection logic for NativeShims in 32 and 64 bit cases #284
Conversation
Test Results: Windows 2 files 2 suites 9s ⏱️ Results for commit f6966ff. ♻️ This comment has been updated with latest results. |
Test Results: Ubuntu 2 files 2 suites 13s ⏱️ Results for commit f6966ff. ♻️ This comment has been updated with latest results. |
Test Results: MacOS 2 files 2 suites 10s ⏱️ Results for commit f6966ff. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the native shims path detection logic in the Net47Implementation class by considering both OS architecture and process bitness. The change ensures that 32-bit processes running on 64-bit systems are correctly mapped to the "x86" directory, providing more accurate architecture detection.
Key changes:
- Updated
NativeShimsPathproperty to use a tuple-based pattern matching approach - Incorporated both
RuntimeInformation.OSArchitectureandEnvironment.Is64BitProcessfor precise directory selection - Improved error message formatting by removing extra space
Co-authored-by: Copilot <[email protected]>
Minimum allowed line rate is |
This pull request refines the logic for determining the native shims path in the
Net47Implementationclass by incorporating both OS architecture and process bitness. This change improves accuracy and robustness when selecting the appropriate directory for native shims.Key change:
Yubico.Core/src/Yubico/PlatformInterop/Libraries.Net47.cs: Updated theNativeShimsPathproperty to use a tuple ofRuntimeInformation.OSArchitectureandEnvironment.Is64BitProcessfor more precise handling of architecture and process bitness. This ensures that 32-bit processes on 64-bit systems are correctly mapped to the "x86" directory.Fixes: #193