[BUG] (NET47) The SDK does not correctly output Yubico.NativeShims.dll when targeting x86 or x64 for NET47

[DennisDyallo]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

This is closely related to #159.

The relevant comments are here by @romerod

Expected Behavior

The expected behaviour is that when we target x86 or x64, the Yubico.NativeShims.dll dll will reside in the respective x86 or x64 folders.

Steps To Reproduce

No response

Version

1.12.0

Version

5.7.0

Anything else?

No response

[romerod]

I've was able to check the new version, there is still an issue with:
https://github.com/Yubico/Yubico.NET.SDK/pull/211/files#diff-0117ba3f3674681073863678e0159bfb2887e648f1381ca501c564f72a51f489L75-R82

From what I've tested it should be:
Path.Combine(
AppDomain.CurrentDomain.BaseDirectory,
(RuntimeInformation.OSArchitecture, Environment.Is64BitProcess) switch
{
{OSArchitecture: Architecture.X86}
or { OSArchitecture: Architecture.X64, Is64BitProcess: false } => "x86",
{ OSArchitecture: Architecture.X64, Is64BitProcess: true } => "x64",
{ OSArchitecture: Architecture.Arm64 } => "arm64",
var unsupportedArch => throw new ArgumentOutOfRangeException(
$"Architecture {unsupportedArch} is not supported!")
},
NativeShims);

Sorry I've got that wrong in the comments.

[DennisDyallo]

Hi @romerod, thanks again for looking into this. My focuses have been elsewhere lately.
Well done, that's a sneaky gotcha.

I recently pushed a PR #284 with your suggested edits.
Please review the PR if you have time and we'll merge it in an upcoming release. Apologies for all the back and forward.