Exclude threading in wasm build. #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fulgen301
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When threading is enabled for a WebAssembly app, this is achieved via the SharedArrayBuffer API.
This places additional constraints on the HTTP headers for the web server that serves the resources for the app in order for the app to use threads. If threads are available at SDL_Init(), the SDL subsystem will attempt to create threads for itself, and if the HTTP headers are not set correctly, SDL_Init() fails.
However, we do not need threading support in the wasm build at all, as this support is only necessary if we build in fluidsynth, which is not currently part of the x16-emulator wasm build.
Closes #331