Skip to content

Circular Option Picker: Use 'placement' prop for popover positioning #70359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Circular Option Picker: Use 'placement' prop for popover positioning #70359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/src/circular-option-picker/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type { Meta, StoryFn } from '@storybook/react';
/**
* WordPress dependencies
*/
import { useState, createContext, useContext } from '@wordpress/element';
import { createContext, useContext, useState } from '@wordpress/element';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (non-blocking): This could be due to an ESLint or Prettier configuration, but I recommend avoiding unrelated changes in the future.

/**
* Internal dependencies
*/
Expand Down Expand Up @@ -152,7 +152,7 @@ WithDropdownLinkAction.args = {
actions: (
<CircularOptionPicker.DropdownLinkAction
dropdownProps={ {
popoverProps: { position: 'top right' },
popoverProps: { placement: 'top-end' },
renderContent: () => (
<div>This is an example of a DropdownLinkAction.</div>
),
Expand Down
Loading