Circular Option Picker: Use 'placement' prop for popover positioning #70359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
22 tasks
t-hamano
added
[Type] Code Quality
Mamaduka
approved these changes
Jun 11, 2025
| @@ -5,7 +5,7 @@ import type { Meta, StoryFn } from '@storybook/react'; | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { useState, createContext, useContext } from '@wordpress/element'; | |||
| import { createContext, useContext, useState } from '@wordpress/element'; | |||
There was a problem hiding this comment.
Suggestion (non-blocking): This could be due to an ESLint or Prettier configuration, but I recommend avoiding unrelated changes in the future.
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ordPress#70359) Co-authored-by: Infinite-Null <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #44401
This PR updates the Circular Option Picker storybook to use the placement prop instead of the deprecated position prop for its popover.
Why?
The Popover component, used internally by Dropdown, has deprecated the position prop in favor of placement. This update brings the Circular Option Picker storybook in line with the latest standards and maintains consistency with other updated components.
How?
Updated the
popoverPropswithin the Circular Option Picker storybook to useplacement: 'top-end'instead ofposition: 'top right'.Testing Instructions
To test this change:
with DropdownLinkActionstorylearn moreScreenshots: