Skip to content

Improve configuration handling for ScriptDllSource #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2021
Merged

Improve configuration handling for ScriptDllSource #214

merged 5 commits into from
Feb 22, 2021

Conversation

enteryournamehere
Copy link
Member

  • Add default value when generating config.default.xml
  • Unlike previously, this default value is not attempted to load when another value is supplied in the config file
  • Throw a descriptive error and quit if no valid script dll sources are configured at all

MickVermeulen
MickVermeulen approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@MickVermeulen MickVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MickVermeulen MickVermeulen merged commit 269470e into dev Feb 22, 2021
@MickVermeulen MickVermeulen deleted the enhancement/script-dll-config branch February 22, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickVermeulen MickVermeulen MickVermeulen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enteryournamehere @MickVermeulen