Merge pull request #214 from UchuServer/enhancement/script-dll-config

Improve configuration handling for ScriptDllSource

Author: MickVermeulen

Uchu.Core/Config/UchuConfiguration.cs

@@ -144,7 +144,7 @@ public class ServerDllSource
         /// <summary>
         /// The path to the Uchu.Instance DLL
         /// </summary>
-        [XmlElement] public string Instance { get; set; } = "Uchu.Instance.dll";
+        [XmlElement] public string Instance { get; set; } = "Enter path to Uchu.Instance.dll";
 
         /// <summary>
         /// The path to the script source DLLs

Uchu.Master/MasterServer.cs

@@ -218,6 +218,8 @@ private static async Task ConfigureAsync()
             {
                 LogQueue.Config = Config = new UchuConfiguration();
 
+                Config.DllSource.ScriptDllSource.Add("Enter path to Uchu.StandardScripts.dll");
+
                 var backup = File.CreateText("config.default.xml");
 
                 serializer.Serialize(backup, Config);
@@ -265,10 +267,24 @@ private static async Task ConfigureAsync()
 
             if (!File.Exists(DllLocation))
             {
-                Logger.Error("Could not find file specified in DllSource -> Instance in config.xml.");
-                throw new FileNotFoundException("Could not find Instance file.");
+                throw new FileNotFoundException("Could not find file specified in <Instance> under <DllSource> in config.xml.");
             }
 
+            var validScriptPackExists = Config.DllSource.ScriptDllSource.Exists(scriptPackPath =>
+            {
+                if (File.Exists(scriptPackPath))
+                    return true;
+
+                Logger.Warning($"Could not find script pack at {scriptPackPath}");
+                return false;
+            });
+
+            if (!validScriptPackExists)
+            {
+                throw new FileNotFoundException("No valid <ScriptDllSource> specified under <DllSource> in config.xml.\n"
+                                                + "Without Uchu.StandardScripts.dll, Uchu cannot function correctly.");
+            }
+            
             foreach (var scriptPackPath in Config.DllSource.ScriptDllSource)
             {
                 if (!File.Exists(scriptPackPath))