Fix major issues and perms

.gitignore

@@ -568,3 +568,5 @@ fabric.properties
 # End of https://www.gitignore.io/api/rider,csharp,visualstudio
 
 .DS_Store
+
+*.bat

Uchu.World/Handlers/Commands/CharacterCommandHandler.cs

@@ -8,6 +8,7 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 using System.Threading.Tasks;
+using System.IO;
 using Uchu.Core;
 using Uchu.Core.Client;
 using Uchu.Core.Resources;
@@ -86,6 +87,7 @@ public string ChangeCoin(string[] arguments, Player player)
         {
             if (arguments.Length != 1) return "coin <delta>";
 
+            /// We parse this as an int instead of long, due to the max long causing bugs. Currency maxes out at a long.
             if (!int.TryParse(arguments[0], out var delta) || delta == default) return "Invalid <delta>";
 
             player.Currency += delta;
@@ -170,7 +172,7 @@ public string Rotation(string[] arguments, Player player)
             return $"{player.Transform.Rotation}";
         }
 
-        [CommandHandler(Signature = "smash", Help = "Smash yourself", GameMasterLevel = GameMasterLevel.Admin)]
+        [CommandHandler(Signature = "smash", Help = "Smash yourself", GameMasterLevel = GameMasterLevel.Player)]
         public async Task<string> Smash(string[] arguments, Player player)
         {
             var animation = "violent";
@@ -517,7 +519,7 @@ public string Stat(string[] arguments, Player player)
             return $"Successfully set {arguments[0]} to {value}";
         }
 
-        [CommandHandler(Signature = "pvp", Help = "Change PvP state", GameMasterLevel = GameMasterLevel.Admin)]
+        [CommandHandler(Signature = "pvp", Help = "Change PvP state", GameMasterLevel = GameMasterLevel.Mythran)]
         public string Pvp(string[] arguments, Player player)
         {
             if (arguments.Length != 1) return "pvp <state(on/off)>";
@@ -759,7 +761,7 @@ public string AddComponent(string[] arguments, Player player)
 
             return $"Successfully added {type.Name} to {player}";
         }
-        
+
         [CommandHandler(Signature = "testmap", Help = "Transfer to world", GameMasterLevel = GameMasterLevel.Mythran)]
         public string World(string[] arguments, Player player)
         {
@@ -777,9 +779,9 @@ public string World(string[] arguments, Player player)
                 return $"Can't find world with ID {id}";
             }
 
-            string WorldName = WorldTable.ZoneName;
+            var path = Path.Combine(UchuServer.Config.ResourcesConfiguration?.GameResourceFolder, Path.Combine("maps", WorldTable.ZoneName.ToLower()));
 
-            if (WorldName.EndsWith(".luz"))
+            if (File.Exists(path) && WorldTable.LocStatus > 0)
             {
                 //
                 // We don't want to lock up the server on a world server request, as it may take time.

Uchu.World/Handlers/Commands/OperatorCommandHandler.cs

@@ -8,6 +8,7 @@
 using Uchu.Core;
 using Uchu.World.Scripting.Managed;
 using Uchu.World.Social;
+using Microsoft.EntityFrameworkCore;
 
 namespace Uchu.World.Handlers.Commands
 {
@@ -236,5 +237,57 @@ public string Target(string[] arguments, Player player)
 
             return $"Target: {baseCombatAiComponent.Target}";
         }
+
+
+        [CommandHandler(Signature = "execute", Help = "Execute a command as another player", GameMasterLevel = GameMasterLevel.Admin)]
+        public async Task<string> Execute(string[] arguments, Player executor)
+        {
+            List<Player> players = new List<Player>();
+            if (arguments[0] == "*") {
+                foreach (var player in executor.Zone.Players) {
+                    players.Add(player);
+                }
+            } else {
+                var player = executor.Zone.Players.FirstOrDefault(p => p.Name == arguments[0]);  // This throws an error if no character is found :shrug:
+                if (player == default) return $"No player named {arguments[0]}";
+                players.Add(player);
+            }
+
+            await using var ctx = new UchuContext();
+            var character = await ctx.Characters.Include(c => c.User).FirstAsync(
+                c => c.Id == executor.Id
+            );
+
+            var _com = new List<string>(arguments);
+            _com.RemoveAt(0);
+
+            var message = string.Join(" ", _com);
+
+            if (!message.StartsWith('/')) {
+                message = "/" + message;
+            }
+
+            if (!SocialHandler.ClientCommands.Contains(message.Split(" ").ElementAt(0)) && message.Split(" ").ElementAt(0) != "/execute" && message.Length > 1) {
+                foreach (Player player in players) {
+                    player.SendChatMessage("You feel a magical power...", PlayerChatChannel.Normal);
+                    var response = await UchuServer.HandleCommandAsync(
+                        message, player, (GameMasterLevel)character.User.GameMasterLevel
+                    );
+
+                    if (!string.IsNullOrWhiteSpace(response)) {
+                        //executor.SendChatMessage($"{player.Name}: {response}", PlayerChatChannel.Normal);
+                        player.SendChatMessage(response, PlayerChatChannel.Normal);
+                    }
+                }
+
+                return $"Executed \"{message}\" as {players.Count} {(players.Count == 1 ? "person" : "people")}";
+            }
+            else
+            {
+                return $"Unable to execute \"{message}\"";
+            }
+
+            return "Failed to execute command";
+        }
     }
 }

Uchu.World/Handlers/SocialHandler.cs

@@ -11,7 +11,7 @@ namespace Uchu.World.Handlers
 {
     public class SocialHandler : HandlerGroup
     {
-        private static string[] ClientCommands = { "/quit", "/exit", "/logoutcharacter", "/camp", "/logoutaccount", "/logout", "/say", "/s",
+        public static string[] ClientCommands = { "/quit", "/exit", "/logoutcharacter", "/camp", "/logoutaccount", "/logout", "/say", "/s",
             "/whisper", "/w", "/tell", "/team", "/t", "/location", "/locate", "/loc", "/faq", "/faqs", "/shop", "/store", "/minigames", "/forums",
             "/thumbsup", "/thumb", "/thumb", "/victory", "/backflip", "/clap", "/cringe", "/cry", "/dance", "/gasp", "/giggle", "/talk", "/salute",
             "/shrug", "/sigh", "/wave", "/why", "/thanks", "/yes", "/addfriend", "/removefriend", "/addignore", "/removeignore", "/recommendedperfoptions",
@@ -40,6 +40,8 @@ public async Task ParseChatMessageHandler(ParseChatMessage message, Player playe
             if (message.Message.StartsWith('/') && !ClientCommands.Contains(message.Message.Split(" ").ElementAt(0)))
             {
 
+                //Logger.Debug($"message.Message: {message.Message}");
+
                 if (ClientCommands.Contains(message.Message.Split(" ").ElementAt(0)))
                     return;
 

Uchu.World/Objects/Components/ReplicaComponents/CharacterComponent.cs

@@ -137,7 +137,10 @@ private void WritePart4(BitWriter writer)
 
             writer.WriteBit(IsPvP);
             writer.WriteBit(IsGameMaster);
-            writer.Write(GameMasterLevel);
+
+            //writer.Write(GameMasterLevel); // Original code
+            //writer.Write((GameMasterLevel != 1 ? GameMasterLevel : 0)); // This broke the component
+            writer.Write(GameMasterLevel != 1 ? GameMasterLevel : (byte)0); // This casts to the correct type (u8)
 
             writer.WriteBit(false); // ???
             writer.Write<byte>(0); // ???

Uchu.World/Objects/GameObjects/InstancingUtilities.cs

@@ -126,6 +126,7 @@ public static GameObject InstantiateLoot(Lot lot, Player owner, GameObject sourc
         public static void InstantiateCurrency(int currency, Player owner, GameObject source, Vector3 spawn)
         {
             if (owner is null) return;
+            if (currency <= 0) return;
 
             try
             {