Fix major issues and perms #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, /pvp was admin only. This is now a Mythran level command. Also added .bat files to the gitignore (I use bat files to build and run the server)
- Fixed Character component (you can see other people's equipment and also equip things again) - Add a /execute command for admins (this still has issues) - Coins with 0 value (showing up as a question mark) no longer drop - Fix permissions on /smash
elenawinters
changed the title
elenawinters
added
type: enhancement
The code wasn't casting to the correct type.
This just moved the explicit cast to the 0, since that's the only thing we are really worried about.
MickVermeulen
requested changes
Dec 26, 2020
| @@ -86,6 +87,7 @@ public string ChangeCoin(string[] arguments, Player player) | |||
| { | |||
| if (arguments.Length != 1) return "coin <delta>"; | |||
|
|
|||
| /// We parse this as an int instead of long, due to the max long causing bugs. Currency maxes out at a long. | |||
There was a problem hiding this comment.
Really nitpicky but we generally only use double slash comments inline and use triple slash comments for doc strings
| public async Task<string> Execute(string[] arguments, Player executor) | ||
| { | ||
| List<Player> players = new List<Player>(); | ||
| if (arguments[0] == "*") { |
There was a problem hiding this comment.
The code in this block doesn't adhere to the overall Uchu / C# style, we generally do:
if ()
{
... stuff
}
else
{
... other stuff
}
and
foreach ()
{
... stuff
}
| c => c.Id == executor.Id | ||
| ); | ||
|
|
||
| var _com = new List<string>(arguments); |
There was a problem hiding this comment.
Bit of a odd variable name, if you meant command I would just use command here
|
|
||
| if (!SocialHandler.ClientCommands.Contains(message.Split(" ").ElementAt(0)) && message.Split(" ").ElementAt(0) != "/execute" && message.Length > 1) { | ||
| foreach (Player player in players) { | ||
| player.SendChatMessage("You feel a magical power...", PlayerChatChannel.Normal); |
There was a problem hiding this comment.
Lol I like this little extra
|
|
||
|
|
||
| [CommandHandler(Signature = "execute", Help = "Execute a command as another player", GameMasterLevel = GameMasterLevel.Admin)] | ||
| public async Task<string> Execute(string[] arguments, Player executor) |
There was a problem hiding this comment.
I'd appreciate a doc string here with maybe some example usage
Also added a check on execute command if empty
We can teleport now
|
All looks good, if you tested the TP GM feel free to merge :) |
MickVermeulen
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.