Skip to content

Update @manypkg/* packages to be ESM only #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 26, 2025

Conversation

spanishpear
Copy link
Contributor

@spanishpear spanishpear commented Apr 21, 2025

It was mentioned in the e18e discord that manypkg might be interested in moving it's packages to ESM-only.

This is a draft PR that:

  • adds type: "module" to all @manypkg/ packages
  • creates a minor patch range (I believe it was agreed since it's a 0.x version, don't need major?)
  • updates p-limit (> v4 is esm only)
  • updates relevant dev deps (preconstruct)

I really tried to avoid exploding scope, but along the way I:

  • added node-version file, updating a previously implicit 18 -> to explicit 22 (might revert this bump, it has wider implications)
  • updated CI to use said node version

Putting a draft PR up before I sleep, I think just need to fix the manypkg/cli loader error ⬇️

$ /home/dev/contrib/manypkg/node_modules/.bin/manypkg check
node:internal/modules/esm/get_format:183
  throw new ERR_UNKNOWN_FILE_EXTENSION(ext, filepath);
        ^

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /home/shrey/dev/contrib/manypkg/packages/cli/src/index.ts
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:183:9)
    at defaultGetFormat (node:internal/modules/esm/get_format:209:36)
    at defaultLoad (node:internal/modules/esm/load:116:22)
    at async ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:488:32) {
  code: 'ERR_UNKNOWN_FILE_EXTENSION'
}

Node.js v22.14.0

Copy link

changeset-bot bot commented Apr 21, 2025

🦋 Changeset detected

Latest commit: 6c863dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@manypkg/cli Minor
@manypkg/find-root Major
@manypkg/get-packages Major
@manypkg/tools Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Apr 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

Copy link

socket-security bot commented Apr 21, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn High
[email protected] has a License Policy Violation.

License: CC-BY-3.0 (package/LICENSE.DOCS)

Source

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@spanishpear spanishpear changed the title Update @manypkg/* packages to be ESM only, publish Update @manypkg/* packages to be ESM only Apr 21, 2025
@spanishpear spanishpear marked this pull request as ready for review April 25, 2025 01:14
@Andarist Andarist merged commit 1763058 into Thinkmill:main Apr 26, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants