Update @manypkg/* packages to be ESM only (#242)

* chore: upgrade preconstruct-cli, p-limit, and prepare tsconfig changes

* chore: upgrade the package.json files to use ESM + exports

* chore: add .node-version file for node 22

* chore: upgrade relative imports, remove unused vars, fix many-pkg/cli bin

* fix: no need for brackets

* fix: run prettier across changes :)

* fix: use node 22 in CI

* chore: changeset

* Merge pull request #1 from Andarist/esm-only-fixes

fix stuff

* fix syntax err (#2)

* Fix CI checks (#3)

* Fix TS issues

* fix knip

* fix tests

* bump changes to major

Co-authored-by: Mateusz Burzyński <[email protected]>

* Make CI setup reusable

---------

Co-authored-by: Mateusz Burzyński <[email protected]>

Author: spanishpear

.changeset/mighty-frogs-fail.md

@@ -0,0 +1,8 @@
+---
+"@manypkg/cli": minor
+"@manypkg/find-root": major
+"@manypkg/get-packages": major
+"@manypkg/tools": major
+---
+
+This package is now published as a [pure ESM package](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c).

.github/actions/ci-setup/action.yml

@@ -0,0 +1,13 @@
+name: Setup CI
+
+runs:
+  using: composite
+  steps:
+    - name: Setup Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version-file: ".node-version"
+
+    - name: Install dependencies
+      shell: bash
+      run: yarn install --frozen-lockfile

.github/workflows/changeset-release.yml

@@ -10,21 +10,11 @@ jobs:
     name: Release
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout Repo
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
+      - uses: ./.github/actions/ci-setup
 
-      - name: Set Node.js 18.x
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-
-      - name: Install Yarn
-        run: npm install --global yarn
-
-      - name: Install Dependencies
-        run: yarn
       - run: git branch -a
 
       - name: "Create Pull Request or Publish to npm"

.github/workflows/main.yml

@@ -11,15 +11,8 @@ jobs:
     name: Tests
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-
-      - name: Set Node.js 18.x
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-
-      - name: Install Dependencies
-        run: yarn
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/ci-setup
 
       - name: Run Tests
         run: yarn test
@@ -28,15 +21,8 @@ jobs:
     name: TypeScript
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-
-      - name: Set Node.js 18.x
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-
-      - name: Install Dependencies
-        run: yarn
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/ci-setup
 
       - name: Check Types
         run: yarn tsc
@@ -45,15 +31,8 @@ jobs:
     name: Formatting
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-
-      - name: Set Node.js 18.x
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-
-      - name: Install Dependencies
-        run: yarn
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/ci-setup
 
       - name: Check Formatting
         run: yarn format:check
@@ -62,15 +41,8 @@ jobs:
     name: Knip
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-
-      - name: Set Node.js 18.x
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-
-      - name: Install Dependencies
-        run: yarn
+      - uses: actions/checkout@v4
+      - uses: ./.github/actions/ci-setup
 
       - name: Check Knip
         run: yarn knip

.node-version

@@ -0,0 +1 @@
+v22.14.0

knip.json

@@ -3,7 +3,7 @@
   "ignoreWorkspaces": ["test-gatsby", "packages/gatsby-source-workspace"],
   "workspaces": {
     ".": {
-      "ignoreBinaries": ["gatsby", "manypkg"]
+      "ignoreBinaries": ["gatsby", "packages/cli/bin.js"]
     }
   },
   "ignore": ["__fixtures__/**"]

package.json

@@ -10,7 +10,7 @@
   "scripts": {
     "format": "prettier --write .",
     "format:check": "prettier --check .",
-    "postinstall": "preconstruct dev && manypkg check",
+    "postinstall": "preconstruct dev && NODE_OPTIONS=--experimental-strip-types packages/cli/bin.js check",
     "knip": "knip",
     "release": "preconstruct build && changeset publish",
     "test": "jest",
@@ -29,7 +29,7 @@
     "@babel/preset-typescript": "^7.18.6",
     "@changesets/changelog-github": "^0.4.8",
     "@changesets/cli": "^2.26.0",
-    "@preconstruct/cli": "^2.8.9",
+    "@preconstruct/cli": "^2.8.12",
     "@types/jest": "^29.2.4",
     "@types/normalize-path": "^3.0.0",
     "@types/parse-github-url": "^1.0.0",
@@ -46,8 +46,13 @@
     "packages": [
       "packages/!(gatsby)*"
     ],
+    "exports": {
+      "importConditionDefaultExport": "default"
+    },
     "___experimentalFlags_WILL_CHANGE_IN_PATCH": {
-      "keepDynamicImportAsDynamicImportInCommonJS": true
+      "distInRoot": true,
+      "importsConditions": true,
+      "typeModule": true
     }
   }
 }

packages/cli/bin.js

@@ -1,4 +1,2 @@
 #!/usr/bin/env node
-"use strict";
-
-require(".");
+import "@manypkg/cli";

packages/cli/package.json

@@ -7,16 +7,19 @@
     "directory": "packages/cli"
   },
   "license": "MIT",
-  "main": "dist/manypkg-cli.cjs.js",
-  "module": "dist/manypkg-cli.esm.js",
+  "type": "module",
+  "exports": {
+    ".": "./dist/manypkg-cli.js",
+    "./package.json": "./package.json"
+  },
   "bin": {
     "manypkg": "./bin.js"
   },
   "dependencies": {
     "@manypkg/get-packages": "^2.2.1",
     "detect-indent": "^6.0.0",
     "normalize-path": "^3.0.0",
-    "p-limit": "^2.2.1",
+    "p-limit": "^6.2.0",
     "package-json": "^10.0.1",
     "parse-github-url": "^1.0.2",
     "picocolors": "^1.1.0",

packages/cli/src/checks/EXTERNAL_MISMATCH.ts

@@ -2,8 +2,8 @@ import {
   makeCheck,
   getMostCommonRangeMap,
   NORMAL_DEPENDENCY_TYPES,
-} from "./utils";
-import { Package } from "@manypkg/get-packages";
+} from "./utils.ts";
+import type { Package } from "@manypkg/get-packages";
 import { validRange } from "semver";
 
 type ErrorType = {

packages/cli/src/checks/INCORRECT_REPOSITORY_FIELD.ts

@@ -1,8 +1,8 @@
 import parseGithubUrl from "parse-github-url";
 import normalizePath from "normalize-path";
-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";
 
-import { makeCheck } from "./utils";
+import { makeCheck } from "./utils.ts";
 
 type ErrorType = {
   type: "INCORRECT_REPOSITORY_FIELD";

packages/cli/src/checks/INTERNAL_MISMATCH.ts

@@ -2,9 +2,9 @@ import {
   makeCheck,
   NORMAL_DEPENDENCY_TYPES,
   versionRangeToRangeType,
-} from "./utils";
+} from "./utils.ts";
 import semver from "semver";
-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";
 
 export type ErrorType = {
   type: "INTERNAL_MISMATCH";

packages/cli/src/checks/INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP.ts

@@ -1,5 +1,5 @@
-import { makeCheck, getMostCommonRangeMap } from "./utils";
-import { Package } from "@manypkg/get-packages";
+import { makeCheck, getMostCommonRangeMap } from "./utils.ts";
+import type { Package } from "@manypkg/get-packages";
 import { upperBoundOfRangeAWithinBoundsOfB } from "sembear";
 import semver from "semver";
 

packages/cli/src/checks/INVALID_PACKAGE_NAME.ts

@@ -1,6 +1,6 @@
-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";
+import { makeCheck } from "./utils.ts";
 import validateNpmPackageName from "validate-npm-package-name";
-import { makeCheck } from "./utils";
 
 type ErrorType = {
   type: "INVALID_PACKAGE_NAME";

packages/cli/src/checks/MULTIPLE_DEPENDENCY_TYPES.ts

@@ -1,5 +1,5 @@
-import { makeCheck } from "./utils";
-import { Package } from "@manypkg/get-packages";
+import { makeCheck } from "./utils.ts";
+import type { Package } from "@manypkg/get-packages";
 
 type ErrorType = {
   type: "MULTIPLE_DEPENDENCY_TYPES";

packages/cli/src/checks/ROOT_HAS_PROD_DEPENDENCIES.ts

@@ -1,6 +1,6 @@
-import { makeCheck, sortObject } from "./utils";
+import { makeCheck, sortObject } from "./utils.ts";
 import pc from "picocolors";
-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";
 
 type ErrorType = {
   type: "ROOT_HAS_PROD_DEPENDENCIES";

packages/cli/src/checks/UNSORTED_DEPENDENCIES.ts

@@ -1,5 +1,10 @@
-import { makeCheck, DEPENDENCY_TYPES, sortDeps, isArrayEqual } from "./utils";
-import { Package } from "@manypkg/get-packages";
+import {
+  makeCheck,
+  DEPENDENCY_TYPES,
+  sortDeps,
+  isArrayEqual,
+} from "./utils.ts";
+import type { Package } from "@manypkg/get-packages";
 
 type ErrorType = {
   type: "UNSORTED_DEPENDENCIES";

packages/cli/src/checks/WORKSPACE_REQUIRED.ts

@@ -1,5 +1,5 @@
-import { makeCheck, NORMAL_DEPENDENCY_TYPES } from "./utils";
-import { Package } from "@manypkg/get-packages";
+import { makeCheck, NORMAL_DEPENDENCY_TYPES } from "./utils.ts";
+import type { Package } from "@manypkg/get-packages";
 
 type ErrorType = {
   type: "WORKSPACE_REQUIRED";

packages/cli/src/checks/__tests__/EXTERNAL_MISMATCH.ts

@@ -1,5 +1,5 @@
-import internalMismatch from "../EXTERNAL_MISMATCH";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import internalMismatch from "../EXTERNAL_MISMATCH.ts";
+import { getWS, getFakeWS, getRootWS } from "../../test-helpers.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/INCORRECT_REPOSITORY_FIELD.ts

@@ -1,6 +1,10 @@
-import path from "path";
-import check from "../INCORRECT_REPOSITORY_FIELD";
-import { getWS, getFakeWS, getFakeString, getRootWS } from "../../test-helpers";
+import {
+  getFakeString,
+  getFakeWS,
+  getRootWS,
+  getWS,
+} from "../../test-helpers.ts";
+import check from "../INCORRECT_REPOSITORY_FIELD.ts";
 
 describe("incorrect repository field", () => {
   describe("github", () => {

packages/cli/src/checks/__tests__/INTERNAL_MISMATCH.ts

@@ -1,5 +1,5 @@
-import makeCheck, { ErrorType } from "../INTERNAL_MISMATCH";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck, { ErrorType } from "../INTERNAL_MISMATCH.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/INVALID_DEV_AND_PEER_DEPENDENCY.ts

@@ -1,5 +1,5 @@
-import makeCheck from "../INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck from "../INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/WORKSPACE_REQUIRED.ts

@@ -1,5 +1,5 @@
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
-import makeCheck from "../WORKSPACE_REQUIRED";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck from "../WORKSPACE_REQUIRED.ts";
 let rootWorkspace = getRootWS();
 
 test("should not error if not using workspaceProtocol: require", () => {

packages/cli/src/checks/index.ts

@@ -1,12 +1,12 @@
-import EXTERNAL_MISMATCH from "./EXTERNAL_MISMATCH";
-import INTERNAL_MISMATCH from "./INTERNAL_MISMATCH";
-import INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP from "./INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP";
-import INVALID_PACKAGE_NAME from "./INVALID_PACKAGE_NAME";
-import MULTIPLE_DEPENDENCY_TYPES from "./MULTIPLE_DEPENDENCY_TYPES";
-import ROOT_HAS_PROD_DEPENDENCIES from "./ROOT_HAS_PROD_DEPENDENCIES";
-import UNSORTED_DEPENDENCIES from "./UNSORTED_DEPENDENCIES";
-import INCORRECT_REPOSITORY_FIELD from "./INCORRECT_REPOSITORY_FIELD";
-import WORKSPACE_REQUIRED from "./WORKSPACE_REQUIRED";
+import EXTERNAL_MISMATCH from "./EXTERNAL_MISMATCH.ts";
+import INTERNAL_MISMATCH from "./INTERNAL_MISMATCH.ts";
+import INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP from "./INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP.ts";
+import INVALID_PACKAGE_NAME from "./INVALID_PACKAGE_NAME.ts";
+import MULTIPLE_DEPENDENCY_TYPES from "./MULTIPLE_DEPENDENCY_TYPES.ts";
+import ROOT_HAS_PROD_DEPENDENCIES from "./ROOT_HAS_PROD_DEPENDENCIES.ts";
+import UNSORTED_DEPENDENCIES from "./UNSORTED_DEPENDENCIES.ts";
+import INCORRECT_REPOSITORY_FIELD from "./INCORRECT_REPOSITORY_FIELD.ts";
+import WORKSPACE_REQUIRED from "./WORKSPACE_REQUIRED.ts";
 
 export let checks = {
   EXTERNAL_MISMATCH,

packages/cli/src/checks/utils.ts

@@ -1,4 +1,4 @@
-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";
 import * as semver from "semver";
 import { highest } from "sembear";
 

packages/cli/src/index.ts

@@ -1,13 +1,17 @@
-import path from "path";
-import * as logger from "./logger";
-import { getPackages, Packages, Package } from "@manypkg/get-packages";
-import { Options } from "./checks/utils";
-import { checks } from "./checks";
-import { ExitError } from "./errors";
-import { writePackage, install } from "./utils";
-import { runCmd } from "./run";
-import { upgradeDependency } from "./upgrade";
-import { npmTagAll } from "./npm-tag";
+import path from "node:path";
+import * as logger from "./logger.ts";
+import {
+  getPackages,
+  type Packages,
+  type Package,
+} from "@manypkg/get-packages";
+import type { Options } from "./checks/utils.ts";
+import { checks } from "./checks/index.ts";
+import { ExitError } from "./errors.ts";
+import { writePackage, install } from "./utils.ts";
+import { runCmd } from "./run.ts";
+import { upgradeDependency } from "./upgrade.ts";
+import { npmTagAll } from "./npm-tag.ts";
 import { exec } from "tinyexec";
 import pLimit from "p-limit";
 

packages/cli/src/logger.ts

@@ -1,5 +1,5 @@
 import pc from "picocolors";
-import util from "util";
+import util from "node:util";
 
 function format(
   args: Array<any>,