Skip to content

[Enhancement] modify histogram_statistic cache expire-update logical (backport #57238) #57242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 24, 2025

Why I'm doing:

histogram statistics cache can't be refreshed after collecting histogram in sync mode.

What I'm doing:

Before this PR:

collect new histogram
drop old histogram cache
wait a moment and really update new histogram cache.

This PR:

collect new histogram
update new histogram statistics cache directly and replace old cache

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…57238)

Signed-off-by: stephen <[email protected]>
(cherry picked from commit b524d1d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticStorage.java
@mergify mergify bot added the conflicts label Mar 24, 2025
Copy link
Contributor Author

mergify bot commented Mar 24, 2025

Cherry-pick of b524d1d has failed:

On branch mergify/bp/branch-3.4/pr-57238
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit b524d1d593.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/AnalyzeMgr.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticStorage.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 24, 2025 13:17
@mergify mergify bot closed this Mar 24, 2025
auto-merge was automatically disabled March 24, 2025 13:17

Pull request was closed

Copy link
Contributor Author

mergify bot commented Mar 24, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 24, 2025 13:39
Signed-off-by: stephen <[email protected]>
Copy link

@wanpengfei-git wanpengfei-git merged commit 1806559 into branch-3.4 Mar 24, 2025
30 of 32 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-57238 branch March 24, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants