[Enhancement] modify histogram_statistic cache expire-update logical #57238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
Show resolved
Hide resolved
Signed-off-by: stephen <[email protected]>
stephen-shelby
force-pushed
the
fix_refresh_histogram
branch
from
4444320 to
c722061
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 19 / 23 (82.61%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kangkaisen
approved these changes
Mar 24, 2025
silverbullet233
approved these changes
Mar 24, 2025
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…57238) Signed-off-by: stephen <[email protected]> (cherry picked from commit b524d1d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticStorage.java
Merged
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…57238) Signed-off-by: stephen <[email protected]> (cherry picked from commit b524d1d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticStorage.java
Merged
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 24, 2025
…(backport #57238) (#57241) Signed-off-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 24, 2025
…(backport #57238) (#57242) Signed-off-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
histogram statistics cache can't be refreshed after collecting histogram in sync mode.
What I'm doing:
Before this PR:
collect new histogram
drop old histogram cache
wait a moment and really update new histogram cache.
This PR:
collect new histogram
update new histogram statistics cache directly and replace old cache
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: