Skip to content

[BugFix] fix cardinality estimation on boolean constant value using mcv (backport #57031) #57035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2025

Why I'm doing:

What I'm doing:

  1. convert boolean constant value to '0' or '1' when estimating cardinality using mcv.
  2. add a session variable to control IntersectAddDistinctRule

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…cv (#57031)

Signed-off-by: stephen <[email protected]>
(cherry picked from commit a868d7d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
Copy link
Contributor Author

mergify bot commented Mar 18, 2025

Cherry-pick of a868d7d has failed:

On branch mergify/bp/branch-3.3/pr-57031
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit a868d7dde4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/IntersectAddDistinctRule.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/ReorderIntersectRule.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/statistics/HistogramStatisticsTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Mar 18, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 24, 2025 04:48
Signed-off-by: stephen <[email protected]>
Copy link

@wanpengfei-git wanpengfei-git merged commit a58bb23 into branch-3.3 Mar 24, 2025
30 of 31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-57031 branch March 24, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants