Skip to content

[BugFix] fix cardinality estimation on boolean constant value using mcv #57031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

[BugFix] fix cardinality estimation on boolean constant value using mcv #57031

merged 1 commit into from
Mar 18, 2025

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Mar 18, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

  1. convert boolean constant value to '0' or '1' when estimating cardinality using mcv.
  2. add a session variable to control IntersectAddDistinctRule

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stephen-shelby stephen-shelby requested a review from a team as a code owner March 18, 2025 08:50
@stephen-shelby stephen-shelby force-pushed the fix_intersect branch 2 times, most recently from 804129e to 8475d9c Compare March 18, 2025 09:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 8 / 11 (72.73%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 2 4 50.00% [1828, 1829]
🔵 com/starrocks/sql/optimizer/rule/transformation/IntersectAddDistinctRule.java 1 2 50.00% [49]
🔵 com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java 5 5 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@satanson satanson enabled auto-merge (squash) March 18, 2025 11:58
@andyziye andyziye disabled auto-merge March 18, 2025 11:59
@andyziye andyziye merged commit a868d7d into StarRocks:main Mar 18, 2025
66 of 67 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@stephen-shelby @mergify
[BugFix] fix cardinality estimation on boolean constant value using m…
71ba34f 
…cv (#57031)

Signed-off-by: stephen <[email protected]>
(cherry picked from commit a868d7d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@stephen-shelby @mergify
[BugFix] fix cardinality estimation on boolean constant value using m…
26c1f1f 
…cv (#57031)

Signed-off-by: stephen <[email protected]>
(cherry picked from commit a868d7d)
This was referenced Mar 18, 2025
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Mar 18, 2025
@mergify @stephen-shelby
[BugFix] fix cardinality estimation on boolean constant value using m…
96b6a46 
…cv (backport #57031) (#57036)

Co-authored-by: stephen <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 24, 2025
@mergify @stephen-shelby
[BugFix] fix cardinality estimation on boolean constant value using m…
a58bb23 
…cv (backport #57031) (#57035)

Signed-off-by: stephen <[email protected]>
Co-authored-by: stephen <[email protected]>
Co-authored-by: stephen <[email protected]>
crossoverJie pushed a commit to crossoverJie/starrocks that referenced this pull request Mar 26, 2025
@stephen-shelby @crossoverJie
[BugFix] fix cardinality estimation on boolean constant value using m…
fc0c714 
…cv (StarRocks#57031)

Signed-off-by: stephen <[email protected]>
Signed-off-by: crossoverJie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@stephen-shelby stephen-shelby

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephen-shelby @satanson @kangkaisen @andyziye