[Enhancement] Add medium type of data dir in be_tablets #37070

nshangyiming · 2023-12-14T11:51:51Z

Why I'm doing:
Add storage medium type in be_tablets table so that we can debug some balancing issue.

What I'm doing:

Fixes SR-23394

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp

Signed-off-by: Dejun Xia <[email protected]>

sonarqubecloud · 2023-12-15T07:53:50Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2023-12-15T09:11:30Z

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/system/information/BeTabletsSystemTable.java	1	1	100.00%	[]

github-actions · 2023-12-15T09:30:19Z

[BE Incremental Coverage Report]

❌ fail : 2 / 16 (12.50%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp	1	15	06.67%	[100, 101, 102, 103, 104, 105, 106, 107, 196, 197, 215, 217, 218, 219]
🔵	be/src/storage/tablet.cpp	1	1	100.00%	[]

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp

github-actions · 2024-01-16T11:45:13Z

@Mergifyio backport branch-3.2

github-actions · 2024-01-16T11:45:14Z

@Mergifyio backport branch-3.1

github-actions · 2024-01-16T11:45:16Z

@Mergifyio backport branch-3.0

mergify · 2024-01-16T11:45:17Z

backport branch-3.2

✅ Backports have been created

#39220 [Enhancement] Add medium type of data dir in be_tablets (backport #37070) has been created for branch branch-3.2

github-actions · 2024-01-16T11:45:17Z

@Mergifyio backport branch-2.5

mergify · 2024-01-16T11:45:19Z

backport branch-3.1

✅ Backports have been created

#39221 [Enhancement] Add medium type of data dir in be_tablets (backport #37070) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-01-16T11:45:22Z

backport branch-3.0

✅ Backports have been created

#39222 [Enhancement] Add medium type of data dir in be_tablets (backport #37070) has been created for branch branch-3.0 but encountered conflicts

mergify · 2024-01-16T11:45:24Z

backport branch-2.5

✅ Backports have been created

#39223 [Enhancement] Add medium type of data dir in be_tablets (backport #37070) has been created for branch branch-2.5 but encountered conflicts

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194)

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194) # Conflicts: # fe/fe-core/src/test/resources/sql/scheduler/schema_scan.sql

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194) # Conflicts: # be/src/exec/vectorized/schema_scanner/schema_be_tablets_scanner.cpp # be/src/exec/vectorized/schema_scanner/schema_be_tablets_scanner.h # fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeTabletsSystemTable.java # fe/fe-core/src/test/resources/sql/scheduler/schema_scan.sql

) (#39221) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194) # Conflicts: # fe/fe-core/src/test/resources/sql/scheduler/schema_scan.sql

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194)

) (#39222) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit cceb194)

) (#39220) Co-authored-by: yiming <[email protected]>

) Add storage medium type in be_tablets table so that we can debug some balancing issue. Signed-off-by: Dejun Xia <[email protected]> Signed-off-by: Seaven <[email protected]>

github-actions bot added 3.2 3.1 3.0 2.5 labels Dec 14, 2023

mergify bot assigned nshangyiming Dec 14, 2023

starrocks-cr bot reviewed Dec 14, 2023

View reviewed changes

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp Show resolved Hide resolved

nshangyiming force-pushed the add-medium-type-in-be-tablets branch from 54baee7 to 9a3380a Compare December 14, 2023 11:55

nshangyiming enabled auto-merge (squash) December 15, 2023 07:07

nshangyiming added 2 commits December 15, 2023 15:09

[Enhancement] Add medium type of data dir in be_tablets

7a5b977

Signed-off-by: Dejun Xia <[email protected]>

fix ut

52f58a5

Signed-off-by: Dejun Xia <[email protected]>

nshangyiming force-pushed the add-medium-type-in-be-tablets branch from 88c43d1 to 52f58a5 Compare December 15, 2023 07:10

nshangyiming and others added 3 commits December 15, 2023 15:26

fix format

4fa9525

Signed-off-by: Dejun Xia <[email protected]>

fix ut

339119e

Signed-off-by: Dejun Xia <[email protected]>

Update schema_be_tablets_scanner.cpp

38797ea

gengjun-git approved these changes Jan 16, 2024

View reviewed changes

jaogoy reviewed Jan 16, 2024

View reviewed changes

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp Show resolved Hide resolved

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp Show resolved Hide resolved

Astralidea approved these changes Jan 16, 2024

View reviewed changes

nshangyiming merged commit cceb194 into StarRocks:main Jan 16, 2024

github-actions bot removed the 3.2 label Jan 16, 2024

github-actions bot removed the 3.1 label Jan 16, 2024

github-actions bot removed 3.0 2.5 labels Jan 16, 2024

This was referenced Jan 16, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070) #39220

Merged

[Enhancement] Add medium type of data dir in be_tablets (backport #37070) #39221

Merged

mergify bot mentioned this pull request Jan 16, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070) #39222

Merged

18 tasks

mergify bot mentioned this pull request Jan 16, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070) #39223

Closed

18 tasks

wanpengfei-git pushed a commit that referenced this pull request Jan 16, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070

d7415ac

) (#39221) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.1-merged label Jan 16, 2024

wanpengfei-git pushed a commit that referenced this pull request Jan 17, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070

5fabb1a

) (#39222) Signed-off-by: yiming <[email protected]> Co-authored-by: yiming <[email protected]>

github-actions bot added the 3.0-merged label Jan 17, 2024

wanpengfei-git pushed a commit that referenced this pull request Jan 19, 2024

[Enhancement] Add medium type of data dir in be_tablets (backport #37070

ce3e529

) (#39220) Co-authored-by: yiming <[email protected]>

github-actions bot added 3.2-merged 3.2 3.1 3.0 labels Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Enhancement] Add medium type of data dir in be_tablets #37070

[Enhancement] Add medium type of data dir in be_tablets #37070

Uh oh!

nshangyiming commented Dec 14, 2023 •

edited

Loading

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 15, 2023

Uh oh!

github-actions bot commented Dec 15, 2023

Uh oh!

github-actions bot commented Dec 15, 2023

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

mergify bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

mergify bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

mergify bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

mergify bot commented Jan 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

[Enhancement] Add medium type of data dir in be_tablets #37070

[Enhancement] Add medium type of data dir in be_tablets #37070

Uh oh!

Conversation

nshangyiming commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 15, 2023

Quality Gate passed

Uh oh!

github-actions bot commented Dec 15, 2023

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions bot commented Dec 15, 2023

[BE Incremental Coverage Report]

file detail

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

mergify bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

github-actions bot commented Jan 16, 2024

Uh oh!

mergify bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

nshangyiming commented Dec 14, 2023 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading