[Enhancement] Add medium type of data dir in be_tablets

Signed-off-by: Dejun Xia <[email protected]>

Author: nshangyiming

be/src/exec/schema_scanner/schema_be_tablets_scanner.cpp

@@ -16,12 +16,12 @@
 
 #include "agent/master_info.h"
 #include "exec/schema_scanner/schema_helper.h"
+#include "gen_cpp/Types_types.h" // for TStorageMedium::type
 #include "gutil/strings/substitute.h"
 #include "runtime/string_value.h"
 #include "storage/storage_engine.h"
 #include "storage/tablet.h"
 #include "storage/tablet_manager.h"
-#include "types/logical_type.h"
 
 namespace starrocks {
 
@@ -34,7 +34,7 @@ SchemaScanner::ColumnDesc SchemaBeTabletsScanner::_s_columns[] = {
         {"INDEX_MEM", TYPE_BIGINT, sizeof(int64_t), false},     {"CREATE_TIME", TYPE_BIGINT, sizeof(int64_t), false},
         {"STATE", TYPE_VARCHAR, sizeof(StringValue), false},    {"TYPE", TYPE_VARCHAR, sizeof(StringValue), false},
         {"DATA_DIR", TYPE_VARCHAR, sizeof(StringValue), false}, {"SHARD_ID", TYPE_BIGINT, sizeof(int64_t), false},
-        {"SCHEMA_HASH", TYPE_BIGINT, sizeof(int64_t), false},
+        {"SCHEMA_HASH", TYPE_BIGINT, sizeof(int64_t), false}, {"MEDIUM_TYPE", TYPE_VARCHAR, sizeof(StringValue), false},
 };
 
 SchemaBeTabletsScanner::SchemaBeTabletsScanner()
@@ -86,13 +86,24 @@ static const char* keys_type_to_string(KeysType type) {
     }
 }
 
+static const char* medium_type_to_string(TStorageMedium::type type) {
+    switch (type) {
+        case TStorageMedium::SSD:
+            return "SSD";
+        case TStorageMedium::HDD:
+            return "HDD";
+        default:
+            return "UNKNOWN";
+    }
+}
+
 Status SchemaBeTabletsScanner::fill_chunk(ChunkPtr* chunk) {
     const auto& slot_id_to_index_map = (*chunk)->get_slot_id_to_index_map();
     auto end = _cur_idx + 1;
     for (; _cur_idx < end; _cur_idx++) {
         auto& info = _infos[_cur_idx];
         for (const auto& [slot_id, index] : slot_id_to_index_map) {
-            if (slot_id < 1 || slot_id > 17) {
+            if (slot_id < 1 || slot_id > 18) {
                 return Status::InternalError(strings::Substitute("invalid slot id:$0", slot_id));
             }
             ColumnPtr column = (*chunk)->get_column_by_slot_id(slot_id);
@@ -138,7 +149,7 @@ Status SchemaBeTabletsScanner::fill_chunk(ChunkPtr* chunk) {
                 break;
             }
             case 9: {
-                // num rowt
+                // num rows
                 fill_column_with_slot<TYPE_BIGINT>(column.get(), (void*)&info.num_row);
                 break;
             }
@@ -170,8 +181,8 @@ Status SchemaBeTabletsScanner::fill_chunk(ChunkPtr* chunk) {
                 break;
             }
             case 15: {
-                Slice type = Slice(info.data_dir);
-                fill_column_with_slot<TYPE_VARCHAR>(column.get(), (void*)&type);
+                Slice data_dir = Slice(info.data_dir);
+                fill_column_with_slot<TYPE_VARCHAR>(column.get(), (void*)&data_dir);
                 break;
             }
             case 16: {
@@ -182,6 +193,12 @@ Status SchemaBeTabletsScanner::fill_chunk(ChunkPtr* chunk) {
                 fill_column_with_slot<TYPE_BIGINT>(column.get(), (void*)&info.schema_hash);
                 break;
             }
+            case 18: {
+                // medium type
+                Slice medium_type = Slice(medium_type_to_string(info.medium_type));
+                fill_column_with_slot<TYPE_VARCHAR>(column.get(), (void*)&medium_type);
+                break;
+            }
             default:
                 break;
             }

be/src/exec/schema_scanner/schema_be_tablets_scanner.h

@@ -18,6 +18,7 @@
 
 #include "exec/schema_scanner.h"
 #include "gen_cpp/FrontendService_types.h"
+#include "gen_cpp/Types_types.h" // for TStorageMedium::type
 
 namespace starrocks {
 
@@ -38,6 +39,7 @@ struct TabletBasicInfo {
     std::string data_dir;
     int64_t shard_id{0};
     int64_t schema_hash{0};
+    TStorageMedium::type medium_type;
 };
 
 class SchemaBeTabletsScanner : public SchemaScanner {

be/src/storage/tablet.cpp

@@ -1637,6 +1637,7 @@ void Tablet::get_basic_info(TabletBasicInfo& info) {
     info.data_dir = data_dir()->path();
     info.shard_id = shard_id();
     info.schema_hash = schema_hash();
+    info.medium_type = data_dir()->storage_medium();
     if (_updates != nullptr) {
         _updates->get_basic_info_extra(info);
     } else {

fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeTabletsSystemTable.java

@@ -46,6 +46,7 @@ public static SystemTable create() {
                         .column("DATA_DIR", ScalarType.createVarchar(NAME_CHAR_LEN))
                         .column("SHARD_ID", ScalarType.createType(PrimitiveType.BIGINT))
                         .column("SCHEMA_HASH", ScalarType.createType(PrimitiveType.BIGINT))
+                        .column("MEDIUM_TYPE", ScalarType.createVarchar(NAME_CHAR_LEN))
                         .build(), TSchemaTableType.SCH_BE_TABLETS);
     }
 }