Remove Julia v1.9 get_extension compatibility code #115
Conversation
Since all SciML packages now require Julia v1.10+, we can remove the compatibility checks for `isdefined(Base, :get_extension)` as package extensions are available in all supported Julia versions. This removes unnecessary version checks in extension loading code.
|
Might as well bump the compat to 1.10 and remove the extension triggers from the deps? Otherwise I think the PR as written is breaking for Julia 1.6-1.9 |
|
Ahh I thought we had already done that for all repos, thanks |
|
I'll get a script going to find any other stragglers. This isn't triggering package tests though? |
|
Apparently we no longer test this on 1.6. Thats fine if we bump the compat (although we may want to run the tests on the last 1.6-friendly release one last time to be sure), but on the other hand we probably want to test on 1.11 and pre. |
|
This was a good test of the new downgrade 😅 sorry that rollout was a bit of a mess. @thazhemadam can you help me get downgrade into the https://github.com/SciML/.github/tree/master/.github/workflows and roll that out globally? I think we should just make the normal CI have an option to error on depwarn and turn it off by default just to get the rest of the rollout around, as I'm surprised this repo isn't on the global CI yet. Also, I'm surprised not to see downstream on here, but now we should just wait for the rollout |
Description
This PR removes the compatibility checks for
isdefined(Base, :get_extension)since all SciML packages now require Julia v1.10+, where package extensions are built-in.Changes
Context
As identified in the SciML-wide analysis, all SciML packages have moved to requiring Julia v1.10+ as the minimum version. This makes the compatibility code for checking whether package extensions are available redundant.
The
isdefined(Base, :get_extension)checks were used to support Julia v1.9 where extensions were loaded differently. Since we no longer support v1.9, this code can be safely removed.Testing